Skip to content

fix: improve knowledge validation logic and handle workspace checks #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxg0103 merged 1 commit into from
Oct 19, 2026
+10 −4
Merged

fix: improve knowledge validation logic and handle workspace checks #7372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions apps/knowledge/serializers/knowledge_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,16 @@ class KnowledgeWorkflowActionSerializer(serializers.Serializer):
def is_valid(self, *, raise_exception=False):
super().is_valid(raise_exception=True)
workspace_id = self.data.get("workspace_id")
query_set = QuerySet(Knowledge).filter(id=self.data.get("knowledge_id"))
if workspace_id:
query_set = query_set.filter(workspace_id=workspace_id)
if not query_set.exists():
knowledge = QuerySet(Knowledge).filter(id=self.data.get("knowledge_id")).first()
if not knowledge:
raise AppApiException(500, _("Knowledge id does not exist"))
# 系统触发（workspace_id 为 None）不做空间校验，直接放行；
# 否则仅系统资源（workspace_id 为 "None"）或属于当前空间的知识库可见
if (
workspace_id not in (None, "None")
and knowledge.workspace_id != "None"
and knowledge.workspace_id != workspace_id
):
raise AppApiException(500, _("Knowledge id does not exist"))

def get_query_set(self, instance: Dict):
Expand Down
Loading