Skip to content

[G01] Correct G02 fixture header trace expectation - #167

Merged
jjangg96 merged 1 commit into
mainfrom
codex/issue-1-pr166-public-ci-fixture-fix-2026-11-13
Nov 13, 2026
Merged

jjangg96 merged 1 commit into
mainfrom
codex/issue-1-pr166-public-ci-fixture-fix-2026-11-13

Conversation

@jjangg96

Copy link
Copy Markdown
Contributor

Summary

  • Correct the G02 synthetic RoundTripper header oracle: github.go sets User-Agent but leaves Accept-Encoding unset at this fixture boundary.
  • Preserve the distinction between client request headers and wire-level transport behavior.
  • Record the post-merge failure from Public CI run 43399911927 and the local RED/GREEN result.
  • No production code or live canary change.

Validation

  • RED before correction: go test -race -p=1 -count=1 -tags=g01_pair_fixture -run '^TestControllerProcessHandoffV3ActualBrokerChild$' ./livecanary failed the selected-callee, changed-callee, and forged-receipt cases.
  • GREEN after correction: the same selector passed with Go 1.27.3; build/module caches and temporary files stayed on /Volumes/worktree.
  • git diff --check — PASS.

Refs #1. The parent issue remains open.

@jjangg96

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T09:33:42.224847Z 06d4548 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 06d4548fbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jjangg96
jjangg96 merged commit 227d6f5 into main Nov 13, 2026
1 check passed
@jjangg96
jjangg96 deleted the codex/issue-1-pr166-public-ci-fixture-fix-2026-11-13 branch November 13, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant