Skip to content

fix: guard GitHub520 commit outcome - #317

Open
xuyua9 wants to merge 1 commit into
521xueweihan:mainfrom
xuyua9:codex/github520-action-outcome-guard-20260813
Open

fix: guard GitHub520 commit outcome#317
xuyua9 wants to merge 1 commit into
521xueweihan:mainfrom
xuyua9:codex/github520-action-outcome-guard-20260813

Conversation

@xuyua9

@xuyua9 xuyua9 commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • Treat an empty generated diff as a successful no-op instead of attempting an empty commit.
  • Check steps.commit.outcome so a failed commit cannot be silently treated as success.

Why

The workflow runs the commit step with continue-on-error: true, but checks the nonexistent steps.commit.outputs.status field. This leaves commit failures unobserved and allows the scheduled job to continue to the push step. The explicit no-change branch also avoids treating a normal empty update as a failed commit.

Validation

  • YAML parsing succeeds.
  • Shell regression covers no-change, successful-change, and commit-failure paths.
  • git diff --check
  • actionlint diagnostics are unchanged baseline warnings for the existing v2 actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant