Skip to content

adding functionality for cox regression - #88

Merged
JessUWE merged 12 commits into
mainfrom
87-new-feature-request-adding-functionality-for-cox-regression
Nov 6, 2026
Merged

JessUWE merged 12 commits into
mainfrom
87-new-feature-request-adding-functionality-for-cox-regression

Conversation

@mahaalbashir

Copy link
Copy Markdown
Collaborator

Adding the cox proportional hazards functionality

@mahaalbashir mahaalbashir linked an issue Oct 12, 2026 that may be closed by this pull request
Comment thread R/acro_regression.R Resolved

@jim-smith jim-smith left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question: looks ike you have replicated the underlying R function.

Q1 are there options/capabilities that lifelines supports that R doesn't - which arse being denied to R users by the design choice above?

Q2 how much of the R survival::cxoxph functionality are we not able to replicate?

@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (c0a1c79) to head (fe0a326).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   96.19%   96.72%   +0.53%     
==========================================
  Files           6        6              
  Lines         315      366      +51     
==========================================
+ Hits          303      354      +51     
  Misses         12       12              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahaalbashir
mahaalbashir requested a review from JessUWE November 6, 2026 13:53
@JessUWE
JessUWE merged commit 147f7fb into main Nov 6, 2026
13 checks passed
@JessUWE
JessUWE deleted the 87-new-feature-request-adding-functionality-for-cox-regression branch November 6, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Feature Request] Adding functionality for Cox Regression

3 participants