Repository navigation
Add the Base/StaggeredGrids tutorial - #185
Merged
Merged
Conversation
Face- and node-centered MultiFabs with convert, faces of a tile with nodaltilebox, OverrideSync of the faces shared by boxes, computeDivergence of a face velocity, and the averaging utilities between faces, nodes and cell centers. The divergence is checked to be exactly zero and the averages to reproduce linear functions to round-off. The tutorial is built in 2D and 3D only; the shear flow has no 1D analogue.
Use the ParallelFor overload that takes one box and one function per direction, so the face velocity is set in a single launch per tile instead of a loop over directions.
Replace the three face lambdas and their index-type locals with a small device functor that takes the direction, so the ParallelFor call needs no #if and the docs snippet renders dedented. Say in the README and the Base docs that the tutorial runs in 2D and 3D.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Face- and node-centered MultiFabs with convert, faces of a tile with nodaltilebox, OverrideSync of the faces shared by boxes, computeDivergence of a face velocity, and the averaging utilities between faces, nodes and cell centers. The divergence is checked to be exactly zero and the averages to reproduce linear functions to round-off.
The tutorial is built in 2D and 3D only; the shear flow has no 1D analogue.