Repository navigation
A fix for an approximation quirk before v3 links the decision that removes it - #2169
Merged
Rafael-SOWNet merged 1 commit intoOct 27, 2026
Conversation
…moves it On #2139 the maintainer asked that fixes for approximation quirks made before v3 be simplified away for v3. v3 removes downcasting (#1019, comment 5754734225), and with it the behaviour those fixes work around. For that to happen, the fixes have to be findable, so AGENTS.md asks each one to link the decision in its comment and in its test. A search for the comment id then lists them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2169 +/- ##
=======================================
Coverage 86.41% 86.41%
=======================================
Files 295 295
Lines 64806 64806
Branches 19059 19059
=======================================
Hits 56005 56005
Misses 4771 4771
Partials 4030 4030
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rafael-SOWNet
deleted the
a-pre-v3-approximation-fix-links-the-decision-that-removes-it
branch
October 28, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On #2139, Happypig375 asked: "While these approximation related quirks are fixable early, remember to simplify these changes away for v3."
v3 removes downcasting (#1019). With it go the decimal answers, the rounding onto rationals, and the residuals taken as zero that such fixes work around. For those fixes to be taken out again, they have to be findable. So
AGENTS.mdnow asks each one to link that decision in its comment and in the test that pins it, and a search for5754734225lists them.The paragraph sits after Ask what a thing means before asking how it is computed, which already queues exact evaluation for v3.
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura