Repository navigation
feat: improved webview - #2924
Merged
RohitKushvaha01 merged 5 commits intoOct 26, 2026
Merged
Conversation
Contributor
 [Medium impact] The reviewed changes appear safe to merge, with no outstanding findings. SummaryThe PR expands the WebView API with profiles, runtime settings, navigation helpers, and more events.
Reviews (4) · Last reviewed commit: "fix" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
RohitKushvaha01
force-pushed
the
improved_webview
branch
from
September 22, 2026 10:18
898684a to
4a8713d
Compare
Member
Author
RohitKushvaha01
force-pushed
the
improved_webview
branch
from
September 22, 2026 10:44
4a8713d to
1712f25
Compare
…vents Rework the Acode WebView API end to end. - Incognito mode backed by AndroidX WebKit multi-profile isolation, with reference-counted profiles, automatic cleanup and a documented best-effort fallback when the provider lacks multi-profile support. - Configurable user agent (explicit string or desktop/mobile presets) and a broad set of WebSettings, applied at creation and at runtime on the UI thread. - Expanded event stream (page lifecycle, progress, navigation, errors, console, dialogs, permissions, fullscreen, downloads, scroll) plus navigation/settings helpers, capability probes and registry utilities. - Split the native plugin into WebViewPlugin/WebViewInstance/WebViewOptions/ ProfileManager and the JS into a thin bridge plus a public AcodeWebView API. - Harden profile names (reject non-canonical or reserved names instead of rewriting them) and use the originating profile's cookie jar for downloads.
RohitKushvaha01
force-pushed
the
improved_webview
branch
from
September 22, 2026 10:51
1712f25 to
30ab290
Compare
RohitKushvaha01
marked this pull request as ready for review
October 26, 2026 08:50
Member
Author
Member
Author
github-project-automation
Bot
moved this from In progress
to Done
in The Code Board - Acode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2772