Repository navigation
metrics: record baseline receipts and the render arm - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Persists the measured before/after gate numbers in the repository via the metrics producer, instead of only in the PR.
docs/_generated/gate-baseline.jsonrecords the pre-change arm commands and their measured wall times (activeblockference-gate-baseline/v1), including per-command seconds and acomparableflag.scripts/gate_metrics.pynow reads both receipts and renders a Before and after table plus explicit notes for baseline workloads that are not equivalent:types(old mypy targeted 3.12),test-full(baseline wasuv run pytestwithout--cov/--cov-fail-under=90),docs(links only),manuscript(no variables check).docs/_generated/gate-timings.jsonwas re-recorded with--arm all --arm test --arm render, so the render arm is now recorded rather than "not recorded".docs/gate.mdanddocs/development.mdpoint at the before/after record;docs/_generated/README.mdlists the baseline receipt.Verification
GNN_ROOT=../Generalized_Notation_Notation \ GNN_PYTHON=../Generalized_Notation_Notation/.venv/bin/python \ uv run python scripts/release_check.py --arm all --arm test --arm render \ --timings docs/_generated/gate-timings.json uv run python scripts/gate_metrics.py --check uv run python scripts/release_check.py --arm docs uv run python scripts/check_docs_links.pyAll pass. Recorded after times (s): lint 0.05, types 0.28, test 15.18, test-full 77.03, docs 10.25, manuscript 7.73, gnn 5.74, smoke 6.10, package 12.87, render 11.65; total run 146.96 s.