Repository navigation
GNN: adopt the shared gnn.importers reader at v5.1.0 - #27
Merged
Merged
Conversation
The pin moves from v5.0.3 at 8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1 — a revision that predates src/gnn/importers.py — to v5.1.0 at 75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf, the release that ships it. The interim local reader goes away instead of being reimplemented: * blockference.gnn.load_pin, GNN_PIN_PATH and their pin-shape tests are deleted; the shared reader owns pin discovery, shape normalization and the pointer check. * the gnn arm runs `python -m gnn.importers check --repo . --require-pointer --workflow .github/workflows/ci.yml --job gnn-conformance` from the pinned runtime, then the drift check and the deep pinned-parser conformance check. * scripts/gnn_importer_report.py is the only bridge: it prints the normalized pin and the gnn-importer-variables/v1 map from an interpreter where gnn is importable, which is what validate_gnn_spec.py and manuscript_variables.py consume. * the gnn_* manuscript variables come from importer_variables, so the prose and the conformance job cannot disagree about the pinned revision. * CI provisions the runtime from the two pin fields with a plain JSON read; the workflow keeps no pin reader. Pin and pointer validation, spec parsing, the semantic validator, the B-orientation check, the consistency checker and the recorded parser digests all run against 75c834bd. The gate selection `--arm all --arm test --arm render` passes on this tree.
docxology
added a commit
that referenced
this pull request
Nov 12, 2026
…29) The optional pymdp extra and its lock are recorded as done: the floor moved from >=1.0.1 to >=1.0.5 and uv.lock resolves 1.0.5 (7f8469d, #28). The GNN cutover item now cites its merge (b621126, #27), and the verification notes record this pass: the docs arm and the gnn arm both passed at 7f8469d, with gnn.importers reporting v5.1.0 @ 75c834bd85 and verdict ok. One defect found while checking the tree is recorded as open: ignored.csv is a cadCAD record dump committed by 574a5c1 and nothing references it; .gitignore covers result.csv, results/ and output/ but not that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNN: adopt the shared
gnn.importersreader at v5.1.0This is the GNN–FEP cutover for ActiveBlockference, the last step of the
staged adoption in
docs/workflows/gnn-fep.md.The member contract row for this repository is: role
importer, gateuv run python scripts/release_check.py --arm all, docs indexdocs/README.mdand
docs/documentation-index.md, manuscript producerscripts/manuscript_variables.py, pinspecs/gnn-pin.json, reader armpython -m gnn.importers check --repo ..Pin: old and new revision
v5.0.38f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1v5.1.075c834bd8519dc7b5adc4d24f16bf393cfd1ecdfv5.0.3predatessrc/gnn/importers.py, so the previous pin could not runpython -m gnn.importersat all.v5.1.0is the release that ships it(
git ls-tree -r v5.1.0 --name-only -- src/gnn/importers.pynames the module).The pin keeps its schema (
gnn-importer-pin/v1), repository, recorded date andparser_filescustody digests; the five digests were recomputed from thepinned tree (
git cat-file -p v5.1.0:<path> | shasum -a 256), and/src/gnn/parsers/markdown_parser_parameter.pyhappens to be byte-identicalbetween the two revisions.
What changed
blockference.gnn.load_pin,blockference.gnn.GNN_PIN_PATHand the three tests whose only subject wasthat pin shape were removed. No copy of the reader is vendored, and the
reader is not overlaid on an older parser: the pin and the parser are the
same revision.
gnnarm calls the shared reader from the pinned runtime, then theoffline drift check, then the deep pinned-parser conformance check:
python -m gnn.importers check --repo . --require-pointer --workflow .github/workflows/ci.yml --job gnn-conformance.--require-pointeris onbecause
.github/GNN.mdalready names the pin file, the revision, theworkflow and the job.
scripts/gnn_importer_report.pyis the single bridge: it runs in aninterpreter where
gnnis importable and prints the normalized pin (viafind_pin/read_pin) and thegnn-importer-variables/v1map (viaimporter_variables).scripts/validate_gnn_spec.pyandscripts/manuscript_variables.pyconsume that JSON, so both stop reading thepin JSON themselves.
gnn_*manuscript variables come fromimporter_variables, keepingtheir key names.
gnn_repositoryis now the reader's normalizedorg/nameform rather than the pin's URL form; prose is unaffected.
repository,commit) with a plain JSON read; the workflow keeps no pin reader.validate_gnn_spec.materialize_pinno longermkdtemps outside the run'stemporary directory, so a
GNN_ROOTrun leaves nothing behind. (A staledocs/_build/gnn-fep-migration/tmp/tree from the earlier blocked attemptwas what made the notebook-hygiene test recurse into GNN build output; it is
gitignored debris and was removed, with no tracked change.)
revisions:
docs/gnn.md,docs/gate.md,docs/development.md,docs/manuscript/09_reproducibility.md,.github/GNN.md,.github/AGENTS.md,.github/workflows/README.md,AGENTS.md,README.md,specs/README.md,scripts/README.md,TODO.md.The exact check command and its output
Run in the pinned runtime, which here is the GNN v5.1.0 checkout's own
environment (
GNN_RUNTIME_PYTHON):The deep conformance check run by the arm (receipt:
docs/_build/gnn/validation-receipt.json, ignored):The reader also fails closed in the other direction: with the pointer still
naming the old revision it reported
[error] pointer-revision-unnamed: .github/GNN.md does not name the pinned revision 75c834bd8519and exited 1, which is why the pointer is updated in thesame change.
Gate
uv run python scripts/release_check.py --arm all --arm test --arm renderwith
GNN_RUNTIME_PYTHONset to the pinned v5.1.0 runtime, on this tree at9262dc3:tests/test_gnn_spec.pyalso runs its pinned-parser conformance test with theruntime present (97 passed, 0 skipped). The generated artifacts were refreshed
through their producers, not by hand:
scripts/manuscript_variables.py(no drift on re-run) and
scripts/gate_metrics.pywith the recorded receipt(
--checkpasses, and a second generation is zero-diff).Hosted Actions
No hosted evidence is claimed. Runs on this repository terminate before any step
executes —
ciand CodeQL runs onmainand on PR #26 reportconclusion: failurewith0steps after ~4 s, consistent with the org-wideActions billing lock. The gate above is a local run on this workstation, quoted
with its host and interpreter in
docs/_generated/gate-metrics.md.Merge
Squash-merged as
b6211266fa8530b39c9c8f1e016744ed0f9d62fcon 2026-11-12.