Repository navigation
Preserve the Institute improvements commit history - #21
Merged
Merged
Conversation
Record version and date_recorded in gnn/upstream.json. SKL-2 (SCOPING C9, decision D1): the pin carried only repository, tag and commit, while GNN's downstream adoption guide prescribes four core keys including the upstream version string and the date the pin was recorded. version is 5.0.3, read from pyproject.toml at the pinned revision 8f293d9ba (v5.0.3); date_recorded is 2026-11-01, the date the pin file was committed (d0e9258). The pin loader (src/gnn_conformance.py:load_pin) reads only the three existing keys and does not reject unknown keys, and tests/test_gnn_conformance.py asserts only those three fields, so no loader change was needed. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
The upstream branch already carries the reviewed improvements. Keep its tree and retain the original local commits as the second parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the original local Institute improvements commit as a parent of the merge. The current upstream implementation already carries the reviewed behavior, so the merge tree matches the current
maintree.The exact head passed
./gates.sh gnnwith GNN v5.0.3 and 34 tests with zero skips. The repository documents a local required check. The live branch rule currently names the hosted check.