Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/GNN.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

`gnn conformance (pinned)` is defined in `.github/workflows/gates.yml` as the
`gnn-conformance` job and reads `gnn/upstream.json` (schema `gnn-importer-pin/v1`), which
pins `ActiveInferenceInstitute/Generalized_Notation_Notation` at `v5.0.3`
(`8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`). The job's only gate step is
pins `ActiveInferenceInstitute/Generalized_Notation_Notation` at `v5.1.0`
(`75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`). The job's only gate step is
`./gates.sh gnn`, the same arm a contributor runs locally.

The job fetches that commit into its own checkout, then runs `./gates.sh gnn`, which is
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,13 @@ gh pr checks "$PR_NUMBER" --repo "$repo" --required --json name,bucket </dev/nul
jq -e --arg context "$context" 'any(.[]; .name == $context and .bucket == "pass")'
```

For specification edits, start from GNN's [Start Here](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.0.3/docs/START_HERE.md),
[framework integration guide](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.0.3/docs/gnn/integration/framework_integration_guide.md),
and [syntax reference](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.0.3/docs/gnn/reference/gnn_syntax.md).
For specification edits, start from GNN's [Start Here](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.1.0/docs/START_HERE.md),
[framework integration guide](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.1.0/docs/gnn/integration/framework_integration_guide.md),
and [syntax reference](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.1.0/docs/gnn/reference/gnn_syntax.md).
For the wider picture (the adoption patterns sibling repositories use, pin discipline, and
the drift guard these checks implement), see GNN's
[downstream adoption guide](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/main/docs/gnn/integration/downstream_adoption.md),
linked on GNN's default branch because it landed after the v5.0.3 pin.
[downstream adoption guide](https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation/blob/v5.1.0/docs/gnn/integration/downstream_adoption.md)
at the v5.1.0 pin.

### Related repositories

Expand Down
4 changes: 0 additions & 4 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
- Depends on: `asf-skilltree-452-live-reverify`
- Evidence: `gh api repos/NationalSecurityAgency/skills-service/releases/latest --jq .tag_name`; `uv run python scripts/reset_local_skilltree.py --confirm-local-reset --timeout 1200`; `uv run python scripts/validate_docker_digests.py`
- Scholarship lanes: delivery_and_reporting
- [ ] **[asf-gnn-upstream-5-1-adoption](docs/todo/asf-gnn-upstream-5-1-adoption.md)** (validation): Adopt the v5.1.0 GNN upstream pin (currently v5.0.3)
- Scope: gnn/upstream.json pins Generalized_Notation_Notation at v5.0.3 (8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1), while the estate cutover moved the importer repositories to v5.1.0 (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf); this repository was not part of that cutover, so its pin is accurate but behind. The tag is duplicated in five places that must move together: gnn/upstream.json, gnn/README.md, docs/gates.md, .github/GNN.md, and the pinned-record constant plus the scratch-checkout tag in tests/test_gnn_conformance.py, with README.md linking the v5.0.3 tag at three places. scripts/validate_gnn_spec.py extracts the pinned commit with git archive and parses the specification with that checkout's parser, so a metadata-only edit would be drift rather than proof: the bump counts only once ./gates.sh gnn passes against a v5.1.0 checkout. Blocker: the arm fails, never skips, without a prepared v5.1.0 checkout and interpreter (GNN_ROOT/GNN_PYTHON), and the hosted `gnn conformance (pinned)` job cannot stand in for it while Actions is billing-locked org-wide. A local Generalized_Notation_Notation checkout at v5.1.0 already exists on the working host (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf), so the maintainer who runs it can close this.
- Evidence: `git ls-remote --tags https://github.com/ActiveInferenceInstitute/Generalized_Notation_Notation.git (v5.1.0 = 75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf)`; `GNN_ROOT=<v5.1.0 checkout> GNN_PYTHON=<interpreter> ./gates.sh gnn`; `uv run pytest tests/test_gnn_conformance.py -q`
- Scholarship lanes: delivery_and_reporting

### Major Improvements

Expand Down
4 changes: 2 additions & 2 deletions docs/gates.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ pay for a full artifact rebuild. Both use the same pytest selection mechanism

`./gates.sh gnn` validates `gnn/discrete_active_inference_agent.gnn.md` against the parser
revision pinned in `gnn/upstream.json` (required schema `gnn-importer-pin/v1`; missing or
unsupported discriminators are rejected): tag `v5.0.3`,
commit `8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`. It needs a prepared
unsupported discriminators are rejected): tag `v5.1.0`,
commit `75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`. It needs a prepared
pinned checkout and fails — never skips — when `GNN_ROOT` is missing or unusable. The
preparation commands are in [`../README.md`](../README.md#required-local-gnn-check); the
job that runs this arm in CI is `gnn-conformance`, displayed as
Expand Down
56 changes: 0 additions & 56 deletions docs/todo/asf-gnn-upstream-5-1-adoption.md

This file was deleted.

4 changes: 2 additions & 2 deletions gnn/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
`discrete_active_inference_agent.gnn.md` is the Generalized Notation Notation
specification of the discrete-agent kernel's generative model.
`upstream.json` records the parser pin: repository
`ActiveInferenceInstitute/Generalized_Notation_Notation`, tag `v5.0.3`, commit
`8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1`.
`ActiveInferenceInstitute/Generalized_Notation_Notation`, tag `v5.1.0`, commit
`75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf`.

`scripts/validate_gnn_spec.py` extracts that pinned commit with `git archive`
and validates the specification. `tests/test_gnn_conformance.py` checks the
Expand Down
6 changes: 3 additions & 3 deletions gnn/upstream.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"schema": "gnn-importer-pin/v1",
"repository": "ActiveInferenceInstitute/Generalized_Notation_Notation",
"tag": "v5.0.3",
"commit": "8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1",
"recorded": "2026-11-12"
"tag": "v5.1.0",
"commit": "75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf",
"recorded": "2026-11-16"
}
32 changes: 15 additions & 17 deletions tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2150,8 +2150,8 @@ tasks:
phase_exit:
- "PLW1510 resolved via explicit checks or a justified targeted noqa; ruff check returns 0."
- id: asf-gnn-upstream-5-1-adoption
title: Adopt the v5.1.0 GNN upstream pin (currently v5.0.3)
status: todo
title: Adopt the v5.1.0 GNN upstream pin
status: done
scale: minor
surface: validation
owner: gnn/upstream.json
Expand All @@ -2161,21 +2161,19 @@ tasks:
- GNN_ROOT=<v5.1.0 checkout> GNN_PYTHON=<interpreter> ./gates.sh gnn
- uv run pytest tests/test_gnn_conformance.py -q
notes: >-
gnn/upstream.json pins Generalized_Notation_Notation at v5.0.3
(8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1), while the estate cutover moved the importer
repositories to v5.1.0 (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf); this repository was not part
of that cutover, so its pin is accurate but behind. The tag is duplicated in five places that
must move together: gnn/upstream.json, gnn/README.md, docs/gates.md, .github/GNN.md, and the
pinned-record constant plus the scratch-checkout tag in tests/test_gnn_conformance.py, with
README.md linking the v5.0.3 tag at three places. scripts/validate_gnn_spec.py extracts the
pinned commit with git archive and parses the specification with that checkout's parser, so a
metadata-only edit would be drift rather than proof: the bump counts only once
./gates.sh gnn passes against a v5.1.0 checkout. Blocker: the arm fails, never skips, without a
prepared v5.1.0 checkout and interpreter (GNN_ROOT/GNN_PYTHON), and the hosted
`gnn conformance (pinned)` job cannot stand in for it while Actions is billing-locked
org-wide. A local Generalized_Notation_Notation checkout at v5.1.0 already exists on the
working host (75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf), so the maintainer who runs it can
close this.
gnn/upstream.json now pins Generalized_Notation_Notation at v5.1.0
(75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf, recorded 2026-11-16), replacing v5.0.3
(8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1) and joining the estate importer cutover. The
duplicated pin references moved together: gnn/upstream.json, gnn/README.md, docs/gates.md,
.github/GNN.md, the CANONICAL_PIN record in tests/test_gnn_conformance.py, and the README.md
GNN documentation links, which now resolve at the v5.1.0 tag (the downstream adoption guide
exists at that tag, so it no longer links the default branch). The scratch-checkout fixture
in tests/test_gnn_conformance.py builds its own stub tag and never reads the real pin, so it
was left as is. Proof is the required local check rather than a metadata-only edit:
scripts/validate_gnn_spec.py and tests/test_gnn_conformance.py passed with no skips against
a v5.1.0 checkout (GNN_ROOT/GNN_PYTHON) in an offline run, and that result is published as the
`gnn conformance (local)` commit status because the hosted `gnn conformance (pinned)` job
remains billing-locked.
scholarship_plan:
lanes:
- delivery_and_reporting
Expand Down
4 changes: 2 additions & 2 deletions tests/test_gnn_conformance.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@

CANONICAL_PIN = {
"repository": "ActiveInferenceInstitute/Generalized_Notation_Notation",
"tag": "v5.0.3",
"commit": "8f293d9ba810e6eda5c09842d9c7ed9ffa5f92c1",
"tag": "v5.1.0",
"commit": "75c834bd8519dc7b5adc4d24f16bf393cfd1ecdf",
}


Expand Down
Loading