Repository navigation
main is red: StaleCheckpointFreshTurnTests fail after fe4ed3a5 landed on top of 1b45c641 - #741
Merged
Merged
Conversation
The fork-point resume baseline (1b45c64) is an ancestor of the checkpoint by construction, so the stale check built on it could never fire: stale checkpoints resumed instead of being discarded, and a concurrent retained-sandbox lease surfaced as a generic checkpoint-changed failure instead of the explicit lease refusal. The branch tip alone cannot be the signal either, because a same-base branch advance must keep resuming while a base move must discard, and the two are indistinguishable after the pickup's upstream refresh rewrites the base ref. Snapshot the base-branch tip before the pickup refresh and decide staleness as a pre/post-refresh difference: any base move means the checkpoint's base was superseded. Same-base advances leave the base untouched and resume via the fork-point baseline as before; a missing snapshot falls back to base ancestry. Adds a combination test (stale checkpoint plus an advanced tip) proving the discard still stages the fresh turn at the current tip. CodeyBox-Prompt-Revision: 1 Co-Authored-By: CodeyBox <noreply@codeybox.invalid>
CodeyBox-WorkItem: 138337e94f8c4e7e82078b352ca483e3 CodeyBox-Agent: copilot/muse-spark-1.3-contributor CodeyBox-Prompt-Revision: 1 Co-Authored-By: CodeyBox <noreply@codeybox.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated via CodeyBox — work item 138337e94f8c4e7e82078b352ca483e3
Initiated by CodeyBox operator
Co-Authored-By: CodeyBox noreply@codeybox.invalid
🤖 Generated with CodeyBox