Repository navigation
Add Microsoft sign-in and provider-aware unverified-email copy - #246
Conversation
Cloud ships /api/auth/microsoft/start and now names the provider an unverified-email rejection came from in `authProvider`. The sign-in page renders a "Continue with Microsoft" button beside Google, carrying the same `next` and invite, and words `unverified_email` for that provider, falling back to the Google copy when no provider is given. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YZ81buxirGgH4cNoSviwz
Composal Verify · PR #246
Warning This request is merged; previous verification results remain in the history. Preview: https://2a43683b-agentrelay-web.agent-workforce.workers.dev/ Findings
Scenarios
Why these 6 scenarios were selected
Recent verification history
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Preview deployed!
This is a Cloudflare Workers preview version of this PR's build. |
|
Composal Verify: Blocked, not this PR's failure. The check finished There is no code fix for a pending device-approval prompt, and I cannot re-run Composal from here. For reference, the homepage hero PR (#239) merged with Composal in the same Blocked state on scenarios outside its diff. I am not changing this PR for it. Generated by Claude Code |
Cloud's Microsoft sign-in is not yet verified end to end, so the button stays display:none on the login page unless the query string carries microsoft=true. The Google button is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YZ81buxirGgH4cNoSviwz
|
Composal Verify on Both findings describe the same thing: a sign-in link from The likely path: the Verify agent drives the DOM rather than the rendered screen, picks the hidden Microsoft link, and follows Not pushing a fix on this PR for it. If the hidden link is the cause, the alternative is to not render the Microsoft button at all unless Generated by Claude Code |
display:none left the link in the DOM, and an automated verifier followed it to a Cloud route the preview cannot serve. Until Cloud's Microsoft sign-in is verified end to end the button is not rendered at all unless the login query string carries microsoft=true. Google is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YZ81buxirGgH4cNoSviwz
Change
/login, pointing at Cloud's/api/auth/microsoft/startwith the samenextandinvite_tokenhandling as the Google button.GoogleSignInButtonis generalized toSignInButton({ provider, href })(same bfcache/double-click guard and relay rush event); aMicrosoftIconis added; the.googleCSS class becomes.provider, with both buttons in a.providersstack./login?microsoft=true(exact stringtrue) renders it; the Google button is unchanged. (An earlier commit useddisplay: none, but the hidden link stayed in the DOM and an automated verifier followed it to a Cloud route the preview cannot serve, so the button is now omitted entirely.)authErrorMessage(code, provider)reads theauthProviderquery param Cloud now sends (AgentWorkforce/cloud#5588, merged).unverified_emailrenders "Microsoft did not provide a verified email address…" for Microsoft and falls back to the existing Google copy when no or an unknown provider is given. Amicrosoftcode gets its own "We couldn't complete Microsoft sign-in" message.Note: Microsoft emails count as verified only when the Entra app registration emits the optional
xms_edovID-token claim; that portal change is tracked separately.Composal Verify
The Blocked result on this PR is accepted by the author: the blocked "Grok Bot sessions" scenario waits on a Google device-approval prompt unrelated to this diff, and the 404 finding on the previous commit was the verifier following the then-hidden Microsoft link. The four login-page scenarios passed on the earlier commits.
Verification
Rendering the Microsoft button unconditionally makes 2 of the 10 login tests fail, so the omit-by-default behaviour is covered.
🤖 Generated with Claude Code
https://claude.ai/code/session_016YZ81buxirGgH4cNoSviwz