fix(frontend): fit the AI providers page on phones - #6282
Conversation
|
@vedtod07 is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
✅ Thanks @vedtod07! This PR now meets the contribution requirements and has been reopened. A maintainer will review it soon. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes improve narrow-screen layout behavior for settings pages and data tables. Page gutters collapse below ChangesResponsive layout and table sizing
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
On a phone, Settings → AI providers spent 128px of a 390px screen on
px-16gutters. The title rendered as "AI provid…", "Provider setup" sat beside the description and squeezed it to about 125px, and the provider table usedw-full table-fixedso columns compressed instead of scrolling.pageGutterClassnow usespx-4 lg:px-16, the same collapse the sessions screen already uses. Desktop gutters stay 64px fromlgup. The settings header stacks the docs link under the description belowlg. The table keeps aminWidthof the declared columns so Credential, Active models, and Created are reachable by swiping.Fixes #6206.
Testing
Verified locally
Prettier on the touched files. Could not run package vitest here (no
web/node_modulesin this sparse checkout).Added or updated tests
pageWidth.test.ts: gutters arepx-4belowlgandlg:px-16from there, with no barepx-16.dataTableColumnWidths.test.ts: when the container is narrower than the columns,tableMinWidthstays at the declared total sooverflow-xcan scroll.QA follow-up
#6206 asks for real phones, both engines, not DevTools:
/m→ Settings → AI providers. Title reads "AI providers" in full. Swipe the table to reach Credential, Active models, and Created.Demo
Layout mock of the 390px page. Real-phone screenshots still belong in QA as requested on #6206.
Checklist