[fix] scrolling on the Agents page - #6290
Conversation
/agents is a full-height route, so the layout frame is bounded and overflow-hidden. The roster grid that replaced the virtual table brought no scroller of its own, so agents past the first rows were clipped at the frame's bottom edge with no way to reach them. Give the grid the same bounded scroll container the sessions page uses.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe non-browse agents layout wraps ChangesAgents roster layout
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The Agents page now gives the roster its own vertical scroll area while keeping the page controls fixed; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
|
Context
The Agents page could not scroll. Any agent past the first two rows was unreachable: the roster simply stopped at the bottom edge of the window with no scrollbar and no response to the wheel.
/agentsis registered as a full-height route inLayout.tsx, so the shell gives it a bounded frame withoverflow-hidden. That was correct while the page rendered anInfiniteVirtualTable, which scrolled internally. The page later moved to the card roster (AgentsGrid), and the grid brought no scroller of its own, so the content had nothing to scroll inside and was clipped instead.Changes
The grid now sits in its own bounded scroll container inside
PageLayout, so the title and the toolbar stay put and only the roster scrolls.Before:
After:
This is the same pattern the sessions page already uses inside the same full-height frame, and it matches what the page's own rail branch (
NEXT_PUBLIC_AGENT_BROWSE_RAIL=true) does withcontentClassName="overflow-y-auto …". Only the default branch changed.Tests / notes
pushToTalkLabelis no longer exported from@agenta/shared/utils, and@agenta/navigation'sregistry.tstrips the headless-package lint rule). Neither is touched by this PR.InfiniteVirtualTableFeatureShell, which scrolls internally.What to QA