Skip to content

[fix] scrolling on the Agents page - #6290

Open
ashrafchowdury wants to merge 1 commit into
mainfrom
fix/agents-page-scroll
Open

[fix] scrolling on the Agents page#6290
ashrafchowdury wants to merge 1 commit into
mainfrom
fix/agents-page-scroll

Conversation

@ashrafchowdury

Copy link
Copy Markdown
Contributor

Context

The Agents page could not scroll. Any agent past the first two rows was unreachable: the roster simply stopped at the bottom edge of the window with no scrollbar and no response to the wheel.

/agents is registered as a full-height route in Layout.tsx, so the shell gives it a bounded frame with overflow-hidden. That was correct while the page rendered an InfiniteVirtualTable, which scrolled internally. The page later moved to the card roster (AgentsGrid), and the grid brought no scroller of its own, so the content had nothing to scroll inside and was clipped instead.

Changes

The grid now sits in its own bounded scroll container inside PageLayout, so the title and the toolbar stay put and only the roster scrolls.

Before:

<PageLayout className={clsx(pageContentWidthClass, "grow min-h-0")} title="Agents">
    <div className="flex items-center gap-3">…toolbar…</div>
    <AgentsGrid  />
</PageLayout>

After:

<PageLayout className={clsx(pageContentWidthClass, "grow min-h-0")} title="Agents">
    <div className="flex items-center gap-3">…toolbar…</div>
    <div className="min-h-0 flex-1 overflow-y-auto">
        <AgentsGrid  />
    </div>
</PageLayout>

This is the same pattern the sessions page already uses inside the same full-height frame, and it matches what the page's own rail branch (NEXT_PUBLIC_AGENT_BROWSE_RAIL=true) does with contentClassName="overflow-y-auto …". Only the default branch changed.

Tests / notes

  • Local browser verification was not possible: the working tree currently fails to build for unrelated reasons (pushToTalkLabel is no longer exported from @agenta/shared/utils, and @agenta/navigation's registry.ts trips the headless-package lint rule). Neither is touched by this PR.
  • The archived agents page is unaffected. It still renders InfiniteVirtualTableFeatureShell, which scrolls internally.

What to QA

  • Open Agents in a project with more agents than fit on one screen. Scroll. The roster scrolls and the last row and the dashed "New agent" cell are reachable.
  • The page title, the "New agent" button, the search box and the "Archived agents" link stay fixed while the cards scroll under them.
  • Scroll to the very top. The avatars overhanging each card's top edge are not clipped by the scroll edge.
  • Search for a name so only one or two cards match. The short list does not gain a scrollbar and the layout does not jump.
  • Regression: open Archived agents. That table still scrolls and paginates as before.

/agents is a full-height route, so the layout frame is bounded and overflow-hidden.
The roster grid that replaced the virtual table brought no scroller of its own, so
agents past the first rows were clipped at the frame's bottom edge with no way to
reach them. Give the grid the same bounded scroll container the sessions page uses.
@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Blocked Blocked Aug 26, 2026 2:37pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8192cc9e-af55-47e2-af46-81058e23c7c8

📥 Commits

Reviewing files that changed from the base of the PR and between a09a0f0 and 53a6351.

📒 Files selected for processing (1)
  • web/oss/src/components/pages/agents/AgentsPage.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved scrolling on the agents page so the full roster remains accessible in non-browse layouts.
    • Prevented agent listings from being clipped within the page frame.

Walkthrough

The non-browse agents layout wraps AgentsGrid in a flexible container with vertical scrolling. Existing roster content, loading state, actions, and creation callbacks remain unchanged.

Changes

Agents roster layout

Layer / File(s) Summary
Add internal roster scrolling
web/oss/src/components/pages/agents/AgentsPage.tsx
AgentsGrid now renders inside a min-h-0 flex-1 overflow-y-auto container for the non-browse layout.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 53a63

The Agents page now gives the roster its own vertical scroll area while keeping the page controls fixed; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 60.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly explains the Agents page scrolling problem, the bounded-container fix, affected branches, testing limits, and QA steps.
Title check ✅ Passed The title directly identifies the main change: fixing scrolling on the Agents page. It is concise and related to the pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/agents-page-scroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ashrafchowdury ashrafchowdury changed the title [fix] Restore scrolling on the Agents page [fix] scrolling on the Agents page Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Preview URL https://gateway-pr-6290.up.railway.app/w
Project agenta-oss-clone-spike
Image tag pr-6290-251d491
Status Deployed
Railway logs Open logs
Workflow logs View workflow run
Updated at 2026-08-26T14:50:12.494Z

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug frontend ui labels Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug frontend size:S This PR changes 10-29 lines, ignoring generated files. ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant