fix(web): prevent script injection in native directory picker - #336
Open
devdudumuniz wants to merge 2 commits into
Open
fix(web): prevent script injection in native directory picker#336devdudumuniz wants to merge 2 commits into
devdudumuniz wants to merge 2 commits into
Conversation
devdudumuniz
force-pushed
the
security/native-dir-picker-arguments
branch
from
August 30, 2026 01:30
af630d9 to
716fcca
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage ? 95.25%
=======================================
Files ? 171
Lines ? 20103
Branches ? 0
=======================================
Hits ? 19150
Misses ? 953
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@luabida, when convenient, could you review this contribution and the two companion PRs, #337 and #338? They are intentionally separate by scope (security, DBF decoding performance, and web UX), are mergeable, and all 15 checks pass on each PR. I am available to adjust any of them based on your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security
User-controlled title and path values are no longer embedded in PowerShell or AppleScript source.
Validation
pytest -q pysus/tests/web/test_native_dir_picker.pyblack --check pysus/native_dir_picker.py pysus/web/pages/1_client.py pysus/tests/web/test_native_dir_picker.pyflake8 pysus/native_dir_picker.py pysus/web/pages/1_client.py pysus/tests/web/test_native_dir_picker.py