Integrate geometry step killing - #15684
Merged
Merged
Conversation
This commit integrates the geometry-step killing mechanism originally studied by Benedikt Voelkel and Anthony Swain. A step filter is loaded from a ROOT macro named by SimCutParams.stepFilteringMacro and evaluated for every step in addition to the built-in z/R cut, and MCReplayParam.allowStopTrack lets a replay act on it. Both are unset by default. The code is taken from AliceO2Group#12119 https://github.com/benedikt-voelkel/AliceO2/tree/geom-cuts https://github.com/benedikt-voelkel/AliceO2/tree/envelope https://github.com/AnthonySwain/AliceO2/tree/ParticleSpecificMaps and the studies behind it are presented in B. Voelkel, Geometry cuts in MC transport, WP12/13, 11.10.2023 https://indico.cern.ch/event/1334852/contributions/5620122/ A. Swain, Geometric hyperparameter optimisation of ALICE MC transport https://indico.cern.ch/event/1323900/contributions/5571214/ CERN-STUDENTS-Note-2023-164 In addition, we provide run/SimExamples/Geometry_StepFiltering, which runs the whole chain from a reference simulation to a hull-filtered replay, and makeKeepStepCylinders.macro, which is able to rederive the geometry hull from a closed geometry to some extent. Thanks to @galickazuzanna for help in compiling this commit. Co-authored-by: Benedikt Volkel <benedikt-voelkel@users.noreply.github.com> Co-authored-by: Anthony Swain <AnthonySwain@users.noreply.github.com> Co-authored-by: Zuzanna Galicka <galickazuzanna@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
sawenzel
enabled auto-merge (squash)
August 17, 2026 11:58
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit integrates the geometry-step killing mechanism originally studied by Benedikt Voelkel and Anthony Swain. A step filter is loaded from a ROOT macro named by SimCutParams.stepFilteringMacro and evaluated for every step in addition to the built-in z/R cut, and MCReplayParam.allowStopTrack lets a replay act on it. Both are unset by default.
The code is taken from
#12119
https://github.com/benedikt-voelkel/AliceO2/tree/geom-cuts
https://github.com/benedikt-voelkel/AliceO2/tree/envelope
https://github.com/AnthonySwain/AliceO2/tree/ParticleSpecificMaps
and the studies behind it are presented in
B. Voelkel, Geometry cuts in MC transport, WP12/13, 11.10.2023
https://indico.cern.ch/event/1334852/contributions/5620122/
A. Swain, Geometric hyperparameter optimisation of ALICE MC transport
https://indico.cern.ch/event/1323900/contributions/5571214/
CERN-STUDENTS-Note-2023-164
In addition, we provide run/SimExamples/Geometry_StepFiltering, which runs the whole chain from a reference simulation to a hull-filtered replay, and makeKeepStepCylinders.macro, which is able to rederive the geometry hull from a closed geometry to some extent.
Thanks to @galickazuzanna for help in compiling this commit.