Fix wrong field-free media assignment in the beam pipe - #15685
Closed
sawenzel wants to merge 1 commit into
Closed
Conversation
This fixes a problem in the beam pipe media assignment, diagnosed with the o2-sim-geometry-doctor tool (AliceO2Group#15683). 22 volumes of the RB24 warm module, its ion pump and its B1 bellow, and the air shell at r = 79-80 cm, carried media labelled out-of-field, whereas their placements at z = 400-490 cm are inside the 4.2-4.6 kGauss solenoid fringe field. Geant4 honours the label and moved particles through these volumes on straight lines, about 171000 steps per min-bias event. This is now fixed by assigning the in-field counterpart media at the construction site of these volumes. After the change no step in a field-free volume sees a non-zero field. The same volumes are also placed far down the beam line where the field really is zero. These placements now integrate the field too, which is correct but slower. A follow-up gives them cloned volumes of their own and restores the shortcut. Related tickets: https://its.cern.ch/jira/browse/O2-174 https://its.cern.ch/jira/browse/O2-175 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178JHAQ2biaX5ac9ThppBXi
sawenzel
force-pushed
the
fix-nf-media-in-field
branch
from
August 17, 2026 12:52
33fb9e2 to
478932f
Compare
Collaborator
|
This was probably done intentionally, but I'm also not against fixing it. The field component transverse to the particle direction is much smaller than 0.5 T and has little effect on downstream detectors. |
Collaborator
Author
|
Thanks @amorsch : If there is a good reason for this (faster sim?) we can of course keep it. I could benchmark the difference it makes but maybe for consistency reasons it could be worth the simplification. |
Collaborator
|
I agree. |
Collaborator
Collaborator
Author
|
putting on hold (awaiting further benchmark studies + release validation) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the beam pipe media assignment, diagnosed with the o2-sim-geometry-doctor tool (#15683). 22 volumes of the RB24 warm module, its ion pump and its B1 bellow, and the air shell at r = 79-80 cm, carried media labelled out-of-field, whereas their placements at z = 400-490 cm are inside the 4.2-4.6 kGauss solenoid fringe field. Geant4 honours the label and moved particles through these volumes on straight lines, about 171000 steps per min-bias event.
This is now fixed by assigning the in-field counterpart media at the construction site of these volumes. After the change no step in a field-free volume sees a non-zero field. The same volumes are also placed far down the beam line where the field really is zero. These placements now integrate the field too, which is correct but slower. A follow-up gives them cloned volumes of their own and restores the shortcut.
Related tickets:
https://its.cern.ch/jira/browse/O2-174
https://its.cern.ch/jira/browse/O2-175