Skip to content

[PWGJE] Updated GNN b-jet analysis tasks - #17506

Merged
nzardosh merged 5 commits into
AliceO2Group:masterfrom
choich08365:gnnbjet
Aug 20, 2026
Merged

[PWGJE] Updated GNN b-jet analysis tasks#17506
nzardosh merged 5 commits into
AliceO2Group:masterfrom
choich08365:gnnbjet

Conversation

@choich08365

@choich08365 choich08365 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

PWGJE/Tasks/bjetTaggingGnn.cxx

  • Refactored process functions using templates.
  • Updated processes for UE subtraction and SV mass template fit.
  • Applied event selection flags for OO collisions.

PWGJE/Tasks/bjetTreeCreator.cxx

  • Minor revisions: comments for future discussion on using PID info for training the GNN model, track DCA selection criteria matched to main analysis task.

@github-actions github-actions Bot added the pwgje label Aug 19, 2026
@github-actions github-actions Bot changed the title Updated GNN b-jet analysis tasks [PWGJE] Updated GNN b-jet analysis tasks Aug 19, 2026
@github-actions

github-actions Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 56 errors, ⚠️ 16 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Aug 19, 2026
Merged
@choich08365
choich08365 marked this pull request as ready for review August 19, 2026 09:28
@alibuild

alibuild commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 07ae072 at 2026-08-20 07:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 9 errors and 21 warnings.'
Found 9 errors and 21 warnings.
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/a6cccc0d80164103059dfd8d0339b8945edee378/O2Physics-code-check/errors.txt
PWGJE/Tasks/bjetTaggingGnn.cxx:50:1: error: included header type_traits is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:166:31: error: no header providing "TAxis" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:178:8: error: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:632:85: error: no header providing "o2::aod::BkgChargedRhos" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:660:92: error: no header providing "o2::aod::BkgChargedMcRhos" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:700:15: error: member 'largeNegativeNumber' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:701:15: error: member 'largePositiveNumber' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:1084:13: error: member 'nPartInel0' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/bjetTaggingGnn.cxx:1456:14: error: variable 'jetFlavor' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 21 -gt 0 ]]
++ cat /sw/BUILD/a6cccc0d80164103059dfd8d0339b8945edee378/O2Physics-code-check/warnings.txt
PWGJE/Tasks/bjetTaggingGnn.cxx:55:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/bjetTaggingGnn.cxx:145:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:146:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:147:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:148:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:149:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:150:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:151:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:152:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:153:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:154:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:155:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:156:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:157:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:158:54: warning: use designated initializer list to initialize 'EvtSelStage' [modernize-use-designated-initializers]
PWGJE/Tasks/bjetTaggingGnn.cxx:1089:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/bjetTaggingGnn.cxx:1094:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/bjetTaggingGnn.cxx:1533:34: warning: use 'contains' to check for membership [readability-container-contains]
PWGJE/Tasks/bjetTaggingGnn.cxx:1545:34: warning: use 'contains' to check for membership [readability-container-contains]
PWGJE/Tasks/bjetTreeCreator.cxx:52:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGJE/Tasks/bjetTreeCreator.cxx:814:9: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
++ [[ 9 -gt 0 ]]
++ exit 1
--

Full log here.

nzardosh
nzardosh reviewed Aug 20, 2026
View reviewed changes
Comment thread PWGJE/Tasks/bjetTaggingGnn.cxx
Configurable<int> dbNbins{"dbNbins", 3000, "number of bins in axisDbFine"};

Configurable<bool> doDataDriven{"doDataDriven", false, "Flag whether to use fill THnSpase for data driven methods"};
Configurable<bool> doDataDrivenExtra{"doDataDrivenExtra", false, "Flag whether to add extra axes to THnSparses"};
Configurable<bool> doDataDrivenSV{"doDataDrivenSV", false, "Flag whether to subscribe SV tables and to use fill THnSparse for data driven methods for SV"};
Configurable<bool> callSumw2{"callSumw2", false, "Flag whether to call THnSparse::Sumw2() for error calculation"};

Configurable<int> trainingDatasetRatioParam{"trainingDatasetRatioParam", 0, "Parameter for splitting training/evaluation datasets by collisionId"};

@nzardosh nzardosh Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a boolean

Comment thread PWGJE/Tasks/bjetTaggingGnn.cxx
@@ -39,11 +40,16 @@
#include <Framework/runDataProcessing.h>

#include <TH1.h>

@nzardosh nzardosh Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the code checker's recommendations for which headers to include/remove

@nzardosh
nzardosh enabled auto-merge (squash) August 20, 2026 15:50
@nzardosh
nzardosh merged commit f2f81d6 into AliceO2Group:master Aug 20, 2026
13 of 15 checks passed
@alibuild

alibuild commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 3302581 at 2026-08-20 19:17:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/d289952d6b1029a8ca7f255e22b025472ee8f3bf/O2Physics-code-check/errors.txt
PWGJE/Tasks/bjetTreeCreator.cxx:483:45: error: no header providing "M_PI" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@jaimenorman jaimenorman Awaiting requested review from jaimenorman jaimenorman is a code owner
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@choich08365 @alibuild @nzardosh