Skip to content

fix(tests): make isolated_home actually isolate, and apply it to every test #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hotragn wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

fix(tests): make isolated_home actually isolate, and apply it to every test #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a38dfa
fix(tests): isolate the user home on Windows so pytest cannot write t…
Hotragn Aug 18, 2026
5028211
fix(tests): sandbox the user home for every test, not only tests that…
Hotragn Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,22 @@ def bind_inline_executor(
spawner.bind(app.workflows.queue.executor)


@pytest.fixture
@pytest.fixture(autouse=True)
def isolated_home(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Iterator[Path]:
home = tmp_path / "home"
home.mkdir()
# `home_dir()` resolves `~` through `Path.home()`. POSIX reads $HOME, but
# Windows reads %USERPROFILE% and ignores $HOME entirely, so patching only
# $HOME leaves user state pointing at the real `~/.codealmanac`.
monkeypatch.setenv("HOME", str(home))
monkeypatch.setenv("USERPROFILE", str(home))
resolved = Path.home()
if resolved != home:
raise RuntimeError(
"isolated_home failed to redirect the user home: "
f"Path.home() is {resolved}, expected {home}. "
"Tests must never read or write the real ~/.codealmanac."
)
yield home


Expand Down