Repository navigation
Optimize radial calculation for orthogonal cells - #1195
Merged
Merged
Conversation
Contributor
|
Thanks! |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize the single-mask radial distribution calculation for orthogonal
cells.
Profiling showed that essentially all runtime for a representative radial
calculation was concentrated in
Action_Radial::calcRDF_singleMask()andthe distance routines it calls.
For orthogonal cells, this change caches the box lengths once per frame and
performs the orthogonal minimum-image distance calculation directly in the
inner pair loop. Other imaging modes continue to use the existing
DIST2()path.
Using
std::fabs()for the coordinate differences also allows the compilerto generate branchless absolute-value operations in this hot loop.
Performance
Test case:
test/Test_AutoImage/walp_2.strip.dcdradial DOPC :DOPC out ... 0.25 15.0-O3CPU user time:
This is approximately a 38.3% reduction in CPU time, or a 1.62x speedup.
Validation
test/Test_Radialpass.produced by the original code.
Action_Radial.cppwas also compiled successfully with-fopenmpto verify the OpenMP code path.git diff --checkreports no whitespace errors.Non-orthogonal and no-image calculations retain the existing
DIST2()path.