Repository navigation
camera: only write trigger features if different in arv_camera_set_trigger and arv_camera_clear_triggers - #1107
Merged
Conversation
…igger and arv_camera_clear_triggers
feuerste
force-pushed
the
set_trigger_if_different
branch
from
October 12, 2026 06:18
a00c10d to
79e4ec6
Compare
Contributor
Author
|
#1109 will be required for the macOS test to complete. |
Contributor
|
Thanks |
fmeum
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Oct 12, 2026
Updates `aravis` to latest `main` (including AravisProject/aravis#1107) and addresses review feedback from #6485 (removing redundant `overlay/MODULE.bazel` and unused `ARAVIS_DATA_DIR` define).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
arv_camera_set_triggerandarv_camera_clear_triggers:TriggerSelector,TriggerMode,TriggerActivation, andTriggerSourceif their current value differs from the target value, via a newarv_camera_set_string_if_differenthelper.arv_camera_set_trigger, determine the target trigger selector (FrameStart,FrameBurstStart, orAcquisitionStart) first and skip disabling it in the loop overTriggerSelectorentries, avoiding a redundantOff->Ontransition on the target selector.This avoids unnecessary register writes on cameras where writing trigger features (even with the same value or toggling
TriggerModeOffand backOn) can cause side effects or errors (e.g. when read-only or locked in the current camera state).