Repository navigation
Fix Tutorial PrintJSON type mapping and Javadoc typos - #128
Merged
Merged
Conversation
APPrintJsonType.Tutorial was annotated @SerializedName("entrance_name"),
which is a JSONMessagePart type rather than a PrintJSON type. The server
sends type "Tutorial" (docs/network protocol.md), so those messages were
deserialized as null and reported as Unknown.
Also fix the POWER operation doc (copied from MULTIPLY), a missing
possessive, and two sentences missing their article in EventManager.
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
cjmang
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Print/APPrintJsonType.java:Tutorialwas annotated@SerializedName("entrance_name"), which is a JSON message part type (it is used correctly inAPPrintType.java), not a PrintJSON type. The server sends"type": "Tutorial"(seedocs/network protocol.mdin the main Archipelago repo), so those messages currently deserialize tonullandWebSocketreports them asUnknown. Changed to@SerializedName("Tutorial"). This is a behaviour change: Tutorial messages will now arrive asAPPrintJsonType.Tutorialinstead ofUnknown.network/client/SetPacket.java: thePOWERoperation's doc said "Multiplies the current value ... to the power of @value" (copied fromMULTIPLY) -> "Raises the current value ... to the power of @value"; "the servers data storage" -> "the server's data storage".EventManager.java: "supplied Object must have..." -> "The supplied Object must have..." in theregisterListener/unRegisterListenerJavadoc.Apart from the
@SerializedNamevalue, comments/Javadoc only.