Repository navigation
Update the 2.6.2 and 1.16.9 recipes with the current fixes - #27
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dcf2983e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| + .split("\\") | ||
| + .filter((part) => part.length > 0 && part !== "." && part !== ".."); | ||
| + if (parts.length === 0) continue; | ||
| + const target = parts.reduce(child, directory); |
There was a problem hiding this comment.
When an archive contains a normal symlink such as pivot -> ~/.config/Vortex plus a backslash-named entry like pivot\\settings.json, this target is later passed to mkdir and rename, both of which follow pivot. Dropping .. segments does not prevent that traversal, so installing a crafted archive can create or overwrite files outside the extraction directory (the identical code is also added to the 1.16.9 recipe). Reject symlink components or perform the relocation with lstat-based containment checks.
Useful? React with 👍 / 👎.
Brings the older recipes up to the current Linux fixes.
scripts/build-version.py --version 2.6.2, package and AppImage.build-version.pynow refuses a recipe whose.SRCINFOchecksums don't pair with its sources, before downloading anything.