Added netstandard2.0 as a target framework - #38
Conversation
|
Anyone here to review and (hopefully) approve my PR? @HenkKin @lbargaoanu :) |
|
A question out of curiosity: If there is not TargetFramework-specific code here, why even have fixed .NET Framework versions set for the EnumMapping-Project? Why not just keep the whole project netstandard2.0 and not bother about compatibility with newer or older .NET versions? |
Good question, in this case I try to follow root library, I was not aware of missing netstandard2.0. |
|
@HenkKin thanks for the review! I can't complete the PR though, I think there is still a workflow that needs approval or something? |
|
@michaelkollmann Please change build.ps1. Because no-build argument is hiding netstandard20 Last line to: exec { & dotnet pack .\src\AutoMapper.Extensions.EnumMapping\AutoMapper.Extensions.EnumMapping.csproj -c Release -o $artifacts } |
done, removed the "--no-build" parameter |
|
@michaelkollmann new version 6.0.1 is available now. |
Hello,
even though it was removed in some older versions AutoMapper 16 is backwards compatible to netstandard2.0 and net471 projects again.
This means that, right now, there is a compatibility difference between AutoMapper itself and this extension here.
This PR aims to fix that discrepancy.
Decisions:
I have added netstandard2.0 and net472 as target frameworks for this project. I have decided to go with net472 instead of net471 as the xunit.runner.visualstudio reference is only compatible with net472, not net471.
To allow the test proejcts to build and test net472 I have upgraded the "Microsoft.NET.Test.Sdk"-package to 18.9.0.
The test project does not have netstandard2.0 as a target framework as the referenced Microsoft.NET.Test.Sdk project does not build with netstandard2.0 I don't think that this is an issue as netstandard2.0 is only a "standardized" framework type and the proejcts will actually use the net472 or net8 (or newer) project types.
Why this is important:
This is important for the project I am working on. We're currently in the process of modernizing a legacy NET4.8 codebase. To be able to easily migrate to .NET 10 we need to update AutoMapper to the latest version before we do so. This project is one of the dependencies that, right now, stops us from upgrading.
I hope you accept contributions and that you will re-add compatiblity with netstandard2.0 and net472. Thanks!