Skip to content

Prevent accordion recognition from dropping unrelated card content - #3568

Merged
chubes4 merged 1 commit into
trunkfrom
fix/issue-3567-blocks-engine
Oct 27, 2026
Merged

chubes4 merged 1 commit into
trunkfrom
fix/issue-3567-blocks-engine

Conversation

@chubes4

@chubes4 chubes4 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Accordion recognition selected a footer toggle and body panel without checking the remaining content, silently dropping review details. It now rejects incomplete matches: the regression loses author, rating, and date on trunk, but preserves them after this change while classic FAQs still become accordions.

What changed

  • Require the selected control and panel to account for item content, including media and graphics.
  • Preserve supported disclosure icons and saved accordion round trips.
  • Reject unlinked toggles with visible candidate panels as insufficient disclosure evidence.
  • Add a neutral table-driven regression covering review cards, visible bodies, and classic FAQs.
  • Additive safety checks; existing accordion contracts remain supported. Rejected cards use normal conversion instead.

Verification

  • passed on 64290fa. Base trunk@e392171 unchanged.
set -e
cd php-transformer
composer install --no-progress --no-interaction
composer test:canonical
php tests/parity/run.php
composer lint:php
  • CI: pending
Cook run
  • Gate 1: tree 0b60ce67d1319b7abbddcfb806bd711f9879cc87, fingerprint 67434721d0e16fe3020f11062c3c8e5cef31d2f28b8b3fd2b135a092361b1740
  • Publication identity: ambient_gh

AI assistance

Tool: Homeboy (pi) · Model: gpt-6.1-sol (tier roadie/cook-heavy) · Used for: AI inspected the issue, implemented the scoped fix, and verified regression and existing gates.

Closes #3567

@chubes4
chubes4 merged commit 6e1736b into trunk Oct 27, 2026
15 checks passed
@chubes4
chubes4 deleted the fix/issue-3567-blocks-engine branch October 27, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AccordionPattern converts a card with a read-more toggle into core/accordion-item and drops the card's other content

1 participant