chore: Update activity score to only track full epoch proofs - #25370
Open
Rumata888 wants to merge 2 commits into
Open
chore: Update activity score to only track full epoch proofs#25370Rumata888 wants to merge 2 commits into
Rumata888 wants to merge 2 commits into
Conversation
spalladino
approved these changes
Sep 1, 2026
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I pushed #25386 that includes some gas savings. Can you review and merge onto yours if it makes sense?
Contributor
|
Also, let's wait until we have an approved AZIP before merging this one (cc @aminsammara) |
Rumata888
force-pushed
the
is/updating_cheating_problem
branch
from
September 3, 2026 16:49
c02ce3d to
6cc5d30
Compare
## Summary - reuse the current epoch already computed during proof acceptance - cache the packed chain tips for full-proof detection and proven-tip advancement - read the known-existing next checkpoint slot directly instead of repeating checkpoint-number validation - update the gas benchmark results; this saves 1,053 gas per proof submission versus the parent PR implementation, leaving roughly 3,729 gas of net overhead versus the pre-PR baseline ## Tests - `forge fmt --check` - `forge test --offline --match-contract MultiProofTest` - `forge test --offline --match-contract HandleRewardsTest` - `python3 scripts/gas_benchmarks.py`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start updating provers' activity scores only when submitted proofs cover the whole epoch. Previously provers could cheat by only submitting the first checkpoint, which was cheaper.
Also changes the requirement for aztecProofSubmissionEpochs to be at least 1