Repository navigation
Only check feature flags for changes when their refresh interval has elapsed - #771
Open
Rafe Kemmis (kemmis) wants to merge 1 commit into
Open
Rafe Kemmis (kemmis) wants to merge 1 commit into
Rafe Kemmis (kemmis) wants to merge 1 commit into
Conversation
…elapsed RefreshAsync checked every feature flag selector (feature flags and enhanced feature flags) on every refresh pass, so any watcher with a shorter refresh interval, such as a sentinel key, caused feature flags to be checked at that interval and FeatureFlagOptions.SetRefreshInterval was effectively ignored. Limit the feature flag change check to selectors whose watcher's refresh interval has elapsed, matching the behavior in 8.6.1. Fixes Azure#770 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #770.
Problem
RefreshAsyncchecks every feature flag selector for changes, for both feature flags (HEAD /kv?key=.appconfig.featureflag/*) and enhanced feature flags (GET /ff), on every refresh pass.refreshableFfWatchersis only used to decide whether to skip the pass entirely. So any watcher with a shorter interval, such as a sentinel registered viaConfigureRefresh, causes feature flags to be checked at that interval, andFeatureFlagOptions.SetRefreshIntervalis effectively ignored.This regressed in #738. In 8.6.1 the feature flag change check only covered
refreshableFfWatchers.Change
Build the feature flag selectors to check from
refreshableFfWatchers(eachUseFeatureFlagsselector registers a watcher with the same name, label, and tag filters), and pass them toHaveFeatureFlagsChangedandHaveEnhancedFeatureFlagsChangedinstead of_options.FeatureFlagSelectors.FeatureFlagSelectorequality is value-based, so the watched-page lookups still match.When a change is detected, all feature flags are still reloaded, as before.
Testing
FeatureFlagsAreNotCheckedForChangesUntilTheirRefreshIntervalElapses: an individually watched key-value (refreshAll: true, 1s interval) is due while feature flags (1 day interval) are not. It verifies the key-value is checked but neitherCheckConfigurationSettingsAsyncnor a secondGetFeatureFlagsAsyncis called. It fails without the fix and passes with it.FullyQualifiedName!~Integration):KeyVaultReferenceTests.ServerRequestIsMadeWhenDefaultCredentialIsSet, fails identically without this change on a machine without managed identity (IMDS unreachable).