Repository navigation
Conversation
…le commands Regenerate the Network extension from TypeSpec at api-version 2026-03-01, rewrite customizations, add subnet update and nsg rule commands on CLI and PowerShell, refresh help, add OpenSpec specs, and replace fake-backend tests with recorded scenario tests.
|
Azure Pipelines: 5 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az network vnet,az network vnet subnet,az network nsg,az network nsg rule,az network public-ip,az network nic*-AzVirtualNetwork,*-AzVirtualNetworkSubnet,*-AzNetworkSecurityGroup,*-AzNetworkSecurityRule,*-AzPublicIpAddress,*-AzNetworkInterface)Description
This PR regenerates the Network extension from TypeSpec at api-version
2026-03-01and rebuilds its custom logic on top of the new generated code.What changed:
src/Extensions/Network/ModelsandProcessorsare regenerated. All hand-written logic is inCustomization/.CreateOrUpdate*_CustomizationandListAll*_Orchestratorfiles are replaced with per-command customizations (vnet, subnet, NSG, security rule, public IP, NIC create/update/list) and shared helpers (resource ID resolver, tags parser, resource group location lookup, singular/plural list mapping).az network vnet subnet update/Set-AzVirtualNetworkSubnet, andaz network nsg rule create|update|show|list|delete/New|Set|Get|Remove-AzNetworkSecurityRule.NetworkCmdletBase.src/CLI/Help/Docs/network) and PowerShell help (src/PS/Network/help).openspec/specs/network-*.Cli.Testsparameter tests are replaced with 23 recorded scenario tests undertests/Scenario.Tests/Network, replayed on both CLI and PowerShell.nsg rule updatesentpriority: 0when--priority/-Prioritywas not given, and Azure rejected the request (SecurityRuleInvalidPriority). Update now binds priority to a nullable value and keeps the existing priority when it is not given.Notes:
AllowDropUnecryptedVnetfeature. These tests check the sent request body and then expect the service errorsUnsupportedEdgeZoneandCannotUseDropUnencryptedForVnet.VmLifecycleScenarioTests.CreateListShowStopDeallocateStartDeleteVirtualMachineand 2 tests inVMNetworkScenarioTests) fail in playback, because their recordings hold Network calls at the old api-version. They must be re-recorded before this PR leaves draft.Testing Guide
dotnet build azclips.slnx: passed (62 projects, 0 errors)dotnet test tests\Scenario.Tests\Scenario.Tests.csproj --filter "FullyQualifiedName~VirtualNetworkScenarioTests|FullyQualifiedName~SubnetScenarioTests|FullyQualifiedName~NetworkSecurityGroupScenarioTests|FullyQualifiedName~SecurityRuleScenarioTests|FullyQualifiedName~PublicIpScenarioTests|FullyQualifiedName~NetworkInterfaceScenarioTests|FullyQualifiedName~NetworkInterfaceEdgeZoneScenarioTests": passed (25/25, playback)dotnet test tests\Scenario.Tests\Scenario.Tests.csproj --filter "FullyQualifiedName~Scenario.Tests.Vm|FullyQualifiedName~Scenario.Tests.VM": failed (112 passed, 3 failed; see known issue above)python devops/scripts/ci/scan_recordings.py <23 new Network recordings>: passed (no secrets found)openspec validate --specs --strict: passed for all 12network-*specsHistory Notes
[Network]
az network vnet subnet update: Add command to update a subnet[Network]
az network nsg rule: Add create, update, show, list and delete commands[Network]
Set-AzVirtualNetworkSubnet: Add cmdlet to update a subnet[Network]
New-AzNetworkSecurityRule,Set-AzNetworkSecurityRule,Get-AzNetworkSecurityRule,Remove-AzNetworkSecurityRule: Add security rule cmdlets[Network] Regenerate Network commands at api-version 2026-03-01
[Component Name]for customer-facing changes or{Component Name}for non-customer-facing changes, and does not end with trailing punctuation or spaces.