Repository navigation
{DevOps} Separate signed Docker preparation from publishing - #1491
Open
Naga Nandyala (naga-nandyala) wants to merge 3 commits into
Open
Naga Nandyala (naga-nandyala) wants to merge 3 commits into
Naga Nandyala (naga-nandyala) wants to merge 3 commits into
Conversation
Share signed PowerShell Docker build and validation across beta signing and stable release while keeping registry publication separate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Naga Nandyala (naga-nandyala)
requested a review
from a team
as a code owner
November 18, 2026 23:04
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The release-path refactor still needs live beta-sign and stable-release-test validation of Azure DevOps template expansion, signed-artifact hand-off, native AMD64/ARM64 Docker execution, and publication gates.
No open issues 🎉
What changed in this PR
Separates signed PowerShell Docker preparation from registry publication in the AzCLIPS release pipelines. Beta signing now exercises the same build and smoke-validation path as stable releases without publishing images.
Changes:
- Extracts shared AMD64/ARM64 image build and native validation stages for beta signing, stable release, and stable-release-test.
- Derives image versions from verified signed archives and carries them in
artifact-version.txt, separate from the Az module version. - Keeps publication gated on image validation and updates pipeline documentation and the existing wiring assertion.
| File | Description |
|---|---|
devops/scripts/ci/test_pipeline_input_safety.py |
Updates the expected count of signed-artifact consumers. |
.azure-pipelines/templates/dist/stages/publish-docker-to-acr.yml |
Removes image preparation and retains gated publication and registry verification. |
.azure-pipelines/templates/dist/stages/build-signed-powershell-docker.yml |
Adds shared signed-image build, version metadata, and native smoke validation. |
.azure-pipelines/azclips-stable-release.yml |
Invokes shared preparation before Docker publication. |
.azure-pipelines/azclips-stable-release-test.yml |
Uses the same preparation and publication sequence. |
.azure-pipelines/azclips-beta-sign.yml |
Adds signed-image preparation without registry publication. |
.azure-pipelines/AGENTS.md |
Documents stage ownership, version handling, and pipeline behavior. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document distribution/image and Az module version metadata together, and require both signed image architectures to match the release version before publication. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Not applicable; internal Azure DevOps pipeline orchestration.
Description
Separate signed PowerShell Docker image preparation from registry publication so beta signing and stable release exercise the same pre-publication Docker path.
Why
Previously,
publish-docker-to-acr.ymlcombined two responsibilities:Stable release invoked this template, but beta signing intentionally did not publish and therefore skipped the signed PowerShell image build and validation too. As a result, this pre-publication work was only exercised by stable/stable-test, rather than by beta signing.
Daily coverage instead of release-day discovery
Beta signing already runs every day, selecting the latest successful beta build on
main(the beta build itself is triggered by batched CI onmain, not a daily schedule). By including the same signed PowerShell Docker preparation module in that daily signing run, both AMD64 and ARM64 image builds and native smoke tests are exercised every day, even when there are no new source changes.This provides earlier detection of signed-package integration problems, base-image or dependency changes, and image build/runtime failures, instead of first discovering them during a stable release. It does not guarantee every release issue will be caught: registry publication and ACR/MCR delivery checks remain exclusive to stable/stable-test.
Separation of concerns
build-signed-docker.ymlis the single logical module for Docker preparation from signed artifacts. It currently handles PowerShell images and owns both image build and native smoke-validation stages, including their artifact hand-off, shared by beta signing, stable release, and stable-release-test. The module name leaves room for other signed-artifact image families without introducing speculative configuration; the existing PowerShell-specific stage names remain accurate and unchanged.Implementation details
publish-docker-to-acr.yml, preserving their stage IDs, image artifact names, native architecture matrices, and smoke-test scripts.azps-cmdlets-<version>.tar.gz, rather than depending onInit, which does not exist in beta signing. No new version is computed from the signing run or source.artifact-version.txt; retain the separatepowershell-version.txtfor checking the packaged Az module version.Scope
This is Docker-only. It does not combine or change the other signing, signed-distribution verification, native lifecycle validation, Component Governance, or GitHub publication stages. The shared module groups signed PowerShell Docker preparation, not every signed package into a new physical artifact or an umbrella signing template.
Stable-release-test retains its existing verification-only native flow; no full native signed lifecycle stage is added there.
Testing Guide
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s devops/scripts/ci -p test_pipeline_input_safety.py -vgit diff --check.{DevOps}for an internal release-process change