Repository navigation
[logicapp] Support local managed API connection creation - #10524
Merged
Ethan Yang (necusjz) merged 3 commits intoOct 26, 2026
Merged
Ethan Yang (necusjz) merged 3 commits into
Ethan Yang (necusjz) merged 3 commits into
Conversation
Port local managed connection creation onto the published preview, preserving deployed identity behavior and guarded local key publication. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for your contribution Riley Evans (@rllyy97)! We will review the pull request and get back to you soon. |
Retain credential-bearing runtime URL rejection coverage without a literal credential URL that trips the medium-confidence scanner. Add explicit missing-file and signed-in subscription regressions for the original local-target requirement. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Secret-file source-control protection, configured-default handling, and blocking file validation need correction before approval.
4 open issues
What changed in this PR
Extends the Logic Apps Standard preview with managed API connection creation for local projects, building on the existing deployed-app workflow.
Changes:
- Adds path and context targeting, with local Azure scope derived from project settings and command overrides.
- Adds development-key storage and guarded local file publication while preserving deployed connection behavior.
- Updates documentation, regression coverage, and the preview version to
1.0.0b2.
| File | Description |
|---|---|
src/logicapp/setup.py |
Advances the preview package version. |
src/logicapp/README.md |
Documents local creation, authentication, and recovery limits. |
src/logicapp/HISTORY.rst |
Records the new preview capabilities. |
src/logicapp/docs/context-management.md |
Explains local scope without changing context metadata. |
src/logicapp/azext_logicapp/tests/latest/test_testing_foundation_regressions.py |
Pins historical report provenance. |
src/logicapp/azext_logicapp/tests/latest/test_sdk_testing.py |
Updates future-version compatibility coverage. |
src/logicapp/azext_logicapp/tests/latest/test_local_managed_connections.py |
Adds local scope, authentication, publication, and failure coverage. |
src/logicapp/azext_logicapp/tests/latest/test_feedback_contracts.py |
Updates historical and future report compatibility cases. |
src/logicapp/azext_logicapp/tests/latest/test_cli_contract_regressions.py |
Covers local targeting and CLI scope overrides. |
src/logicapp/azext_logicapp/custom.py |
Resolves local and deployed targets. |
src/logicapp/azext_logicapp/_test_report.py |
Updates the report producer version. |
src/logicapp/azext_logicapp/_params.py |
Adds local targeting arguments and optional scope parameters. |
src/logicapp/azext_logicapp/_managed_connection.py |
Integrates local development keys into connection creation. |
src/logicapp/azext_logicapp/_local_managed_connection.py |
Implements local validation, scope resolution, and guarded publication. |
src/logicapp/azext_logicapp/_help.py |
Adds command guidance and local examples. |
Review effort: Balanced
Preserve unknown Git tracking status on fatal errors, publish staging exclusion before writing secrets, reject nonregular configuration files without blocking, and ignore configured group defaults for local/context targets while preserving explicit deployed defaults. Add targeted regressions and clarify local publication guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Ethan Yang (necusjz)
approved these changes
Oct 26, 2026
Collaborator
|
[Release] Update index.json for extension [ logicapp-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=187840996&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🤖 PR Validation —⚠️ Review suggested
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
3 added suppressions
src/logicapp/azext_logicapp/_local_managed_connection.py# pylint: disable=import-error,no-name-in-modulesrc/logicapp/azext_logicapp/_local_managed_connection.pyclass LocalConnectionsFile: # pylint: disable=too-many-instance-attributessrc/logicapp/azext_logicapp/tests/latest/test_local_managed_connections.pyself.skipTest("Git is not installed on this host.")This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az logicapp connection managed createFollow-up to #10467, ported onto upstream
mainwithout staging history. Advances preview1.0.0b1to1.0.0b2, preserving upstream ownership, packaging, review repairs and historical report compatibility.Original issue acceptance:
local.settings.json; explicit flags override settings, with no new context schema.--path, named local/cloud--context, active context without an explicit target, or existing--logic-app-name. Actual CLI/deployed lifecycle regressions pass; local Outlook OAuth plus a real workflow run succeeded.Local scope precedence is explicit
--subscriptionoverValues.WORKFLOWS_SUBSCRIPTION_ID,--resource-groupoverWORKFLOWS_RESOURCE_GROUP_NAME, and--locationoverWORKFLOWS_LOCATION_NAME. Contexts remain local path/port or deployed-site bookmarks. No default-subscription fallback, account switch or scope-setting rewrite. Injected group defaults do not override local settings/cloud contexts; explicit deployed-app targets retain configured-default behavior.Local execution creates a V2 Azure
Microsoft.Web/connectionsresource using existing connector parameters/stdin secrets/OAuth. It requests a seven-day development key, saves it only asNAME-connectionKeyinlocal.settings.json, and writes aRaw/Keyapp-setting reference inconnections.json. Results never return the key and redact runtime URLs. Backend auth supports raw/service-principal/OAuth; local managed-identity and user-assigned identity are refused. Local targets make no site identity/access-policy/remote VFS calls. Existing deployed lifecycle and deployed-only legacyconnection create --managed-apibehavior remain guarded.Preflight rejects missing/malformed/encrypted settings, invalid scope, absent/mismatched signed-in subscriptions, unsafe links/aliases, nonregular files and Git-tracked settings before creation. Existing resources/local wiring require
--force. Publication preserves unrelated content, establishes effective final ignore rules for local settings and private staging before any secret staging contents are written, then uses private staged files, snapshots, an advisory lock and individual atomic replacements. ZIPs/manifests exclude local settings and.azurelogicapps.API-diff warnings are additive target selection: local scope can be derived, so parser-level deployed coordinates become conditional, not removed. Deployed targets still validate required coordinates. Dynamic-import pylint exceptions follow adjacent modules; installed-byte/CLI checks verify imports. The class-scoped instance-attribute exception keeps guarded publication state together. Real-Git tests skip only when Git is absent; they ran here. Actual FIFO tests require hosts supporting FIFOs/nonblocking opens. No scanner suppression was added.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
Not a new extension; that item is not applicable.
Independent upstream validation uses Windows x64/Python 3.14.7/CLI 2.91.0 and private development/configuration/extension directories; these are not staging results.
python -m azdev style logicapppython -m azdev linter logicapppython -m pytest src\logicapp\azext_logicapp\tests\latest\test_local_managed_connections.py src\logicapp\azext_logicapp\tests\latest\test_managed_lifecycle_regressions.py src\logicapp\azext_logicapp\tests\latest\test_cli_contract_regressions.py src\logicapp\azext_logicapp\tests\latest\test_testing_foundation_regressions.py -qpython <session-artifacts>\run_suite.pyusing installed-only Python with production preload/import-origin guardpython <session-artifacts>\smoke_installed.pypython -m azdev scan --confidence-level MEDIUM -f <changed-file> --continue-on-failurepython scripts\ci\test_index.py -qpython scripts\ci\validate_external_source_urls.py --cachedpython -m azdev test logicapp --profile latest --series --discover --no-exitfirst --pytest-args -qEarlier revalidation before AI fixes passed 938 installed tests / 2,559 subtests and 8 stock CLI smoke cases. An initial environment-only rerun omitted extension discovery variables and failed additivity discovery; the correctly configured full rerun passed. Latest post-fix results are in the table above.
Latest repaired wheel SHA256:
f2a4b14d4160db9d670d0247180aefbe75e0195fc69cdf2c78b6c743364c4bd6, built fromcea48b060c265575f4eeafb5c7845b314b8587f2production bytes. First actual Copilot review identified 4 issues; all were fixed, regression-covered, replied to and resolved in that commit: fatal Git exit status, secret staging exclusion, blocking FIFO validation and configured group defaults. A fresh completed AI review and CI on the new head are still required; absence of new comments alone is not a clean review. The earlier permission-denied reviewer API request has not been retried or bypassed; the user is requesting review directly.Historical user-authorized live qualification was on
6305fd9(wheel SHA2560b603f5c6ca212fe1893af134a1f6c53861374c07432155b0fb6590645e2364c): one new local Office365 OAuth connection, user-driven browser consent, private key wiring, and exactly one actual StatefulGetEmailsV3workflow (top: 1, no attachments/retries, secure mailbox-action I/O). Run succeeded with onlycount: 1exposed. Owned runtime/storage stopped; cloud connection/private project retained. No default-account/context changes, global installs, deployed app/ACL/role operations or login. This live trial has not been repeated for the subsequent production safety fixes; deployed behavior remains regression-qualified, not newly live-qualified.Limits: development keys expire after seven days with no auto-renewal; they are not production authentication. Publication is not a multi-file transaction/CAS against noncooperating writers. Failure can retain Azure state and partial local publication; no unsafe rollback/deletion/automatic mutation retry. Unknown Git tracking is reported as
trackedByGit: null, not untracked. No merge or readiness claim until the review cycle completes; this task does not change PR draft/open state.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.