Repository navigation
[k8s-extension] Propagate non-404 delete lookup failures - #10528
Open
Alima Azamat (alimaazamat) wants to merge 1 commit into
Open
Alima Azamat (alimaazamat) wants to merge 1 commit into
Alima Azamat (alimaazamat) wants to merge 1 commit into
Conversation
Keep deletion idempotent for missing extensions while surfacing authorization, throttling, and service failures. Cover the real delete delegate with lookup-failure regression tests and prepare the 1.9.5 dependency release. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3e9999ee-7df3-4e69-9868-14375740b6b3
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 tasks done
3 tasks done
Contributor
|
Thank you for your contribution Alima Azamat (@alimaazamat)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The localized fix preserves existing 404 and successful-delete behavior, with focused regression coverage and no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Corrects the shared k8s-extension delete implementation so failed lookups no longer report success unless the response is HTTP 404. AKS wrappers benefit once the corrected dependency is published and installed.
Changes:
- Preserve idempotent deletion for HTTP 404 and propagate all other lookup errors.
- Add regression coverage for lookup failures, skipped cleanup/deletion, and successful-delete argument forwarding.
- Prepare version
1.9.5with a release-history entry.
| File | Description |
|---|---|
src/k8s-extension/setup.py |
Bumps the package version to 1.9.5. |
src/k8s-extension/HISTORY.rst |
Documents the delete error-propagation fix. |
src/k8s-extension/azext_k8s_extension/tests/latest/test_custom.py |
Tests 404 handling, other lookup failures, and successful deletion. |
src/k8s-extension/azext_k8s_extension/custom.py |
Re-raises non-404 lookup errors before cleanup or deletion. |
Review effort: Balanced
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Summary
Fix the shared
k8s-extension deleteimplementation returning success when its initial extension lookup fails for reasons other than HTTP 404.client.get, plus successful-delete argument forwarding.k8s-extensionversion1.9.5with a release-history entry.Review scope and related PRs
Split out for independent review by the
k8s-extensionmodule owners:This PR contains no
aks-previewor generated-index changes and is based on currentmain.The AKS wrappers delegate to the installed
k8s-extensionpackage. Their normal create/show/list/update paths do not depend on this fix. Correct propagation of non-404 lookup failures during deletion requires this corrected dependency to be published and installed; updatingaks-previewalone does not update the dependency. No minimum-version gate is added by this PR.Validation
azdev style k8s-extension, the repository-scoped command linter, and index tests (9 tests, 2 skipped); the1.9.5wheel built successfully.