Skip to content

[Edge Action] Release 1.1.0 with subscription-scoped listing - #10536

Merged
JaysonTaiMicrosoft merged 4 commits into
Azure:mainfrom
kestry:jeankim-edgeaction-subscription-list
Oct 29, 2026
Merged

JaysonTaiMicrosoft merged 4 commits into
Azure:mainfrom
kestry:jeankim-edgeaction-subscription-list

Conversation

@kestry

@kestry Jean Kim (kestry) commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Suppressions
⚠️ None ️✔️ None
⚠️Azure CLI Extensions Breaking Change Test
⚠️edge-action
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove edge-action list cmd edge-action list update parameter resource_group: removed property required=True

Release Edge Action extension 1.1.0 with subscription-scoped listing. az edge-action list now lists resources in the selected subscription when --resource-group is omitted; supplying the argument preserves resource-group-scoped listing. Both paths use stable API 2026-10-01 and retain pagination.

Companion AAZ models: Azure/aaz#1146, targeting main.

Changes

  • Regenerate the root list command from the merged-scope AAZ model, making --resource-group optional and adding the subscription-list operation/example.
  • Cover both scopes, exact GET routes and API version, resource identity and response fields, empty results, server pagination, and local --max-items/--next-token behavior with offline tests.
  • Exercise the real CLI parser/invoker to verify --subscription overrides the active subscription for both listing scopes.
  • Extend the existing CRUD scenario with subscription-list membership of its created resource ID, without assuming subscription-wide count or ordering. Check non-null validationStatus on deployed versions before and after swapping the default; retain existing skips and stronger successful-deployment checks.
  • Include the user's refreshed eight scenario recordings. Add a replay-only AAZBasePolling._delay patch with cleanup and a regression test proving it is absent from recording hooks and restored afterward.
  • Bump setup.py from 1.0.0 to 1.1.0 and add the matching HISTORY.rst release entry.
  • Preserve custom download, execution-filter update, swap-default polling behavior, and the CRLF upload-fixture rule. No runtime dependencies or shared CI changes.

Release and compatibility

This is a backward-compatible capability addition, so 1.1.0 follows the documented minor-version increment rule. Existing successful resource-group-scoped invocations retain their scope; previously rejected invocations without a resource group can now list subscription-wide.

The breaking-change checker flags removal of the argument's required=True property (rule 1009). That is the intentional relaxation enabling the additional scope, not removal of the argument or its existing behavior. No new suppression is added.

src/index.json is not modified; the normal extension publication pipeline handles the index update after merge.

The extension-local replay hook skips AAZ polling delays only. The shared foreground-yield fix is separate in Azure/azure-cli#34300. The local validation environment includes that shared fix, so playback timing must not be attributed to this extension PR alone.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az edge-action list, with and without --resource-group, including explicit --subscription and pagination options.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

Validation for release-metadata commit 4dc425f125ca78b82e7f7445e95d3f76161bec59, with the virtual environment activated and AZURE_TEST_RUN_LIVE unset:

. .\.venv\Scripts\Activate.ps1
$currentBranch = git branch --show-current
$mergeBase = git merge-base HEAD upstream/main

# Executed by the normal pre-commit hook:
azdev scan
# PASSED.

# Executed by the normal pre-push hook:
azdev linter --min-severity medium --repo ./ --src $currentBranch --tgt $mergeBase
# PASSED: no linter/custom-pylint violations.

azdev style --repo ./ --src $currentBranch --tgt $mergeBase
# PASSED: pylint and flake8.

azdev test --repo ./ --src $currentBranch --tgt $mergeBase --discover --no-exitfirst --xml-path test_results.xml
# PASSED: 65 tests and 80 subtests in 31.30s, including all eight recorded scenarios.

The pre-push hook completed successfully and pushed the release commit. The user-approved rebase and azdev setup refreshed the separate editable Azure CLI environment before these checks. No live Azure operations were run, and the extension working tree was clean after the push. This default-parallel hook run is not an apples-to-apples timing comparison with earlier --series runs.

Earlier validation at 0ee7544cfc72180982e5de3a2ecd1ee6797a3031 also passed:

azdev style edge-action
# PASSED: pylint and flake8.

$env:PYTHONPATH = (Resolve-Path .\src\edge-action).Path
$env:AZURE_TEST_RUN_LIVE = 'false'
.\.venv\Scripts\python.exe -m pytest src\edge-action\azext_edge_action\tests\latest\test_edge_action_custom.py src\edge-action\azext_edge_action\tests\latest\test_edge_action_recording_processors.py -q
# PASSED: 57 tests and 80 subtests.

.\.venv\Scripts\python.exe scripts\ci\test_index.py -q
# PASSED: 9 tests run, 2 skipped.

git diff --check origin/main...HEAD
# PASSED.

The user separately reported eight live tests and eight playback tests passing before supplying the refreshed recordings. Those live runs were not performed by the agent. Current-release-head CI has not yet been assessed here; the bot-managed section above identifies its own evaluated commit.

For new extensions:

This updates an existing extension; its summary is unchanged.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 04:16
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the subscription-scoped listing change.

No open issues 🎉

What changed in this PR

Adds subscription-scoped listing to the Edge Action extension while preserving resource-group listing, stable API 2026-10-01, and pagination. Strengthens offline and scenario coverage without changing runtime dependencies or release metadata.

Changes:

  • Makes --resource-group optional and selects the corresponding list endpoint.
  • Expands checks for subscription overrides, pagination, response fields, and deployed-version validation status.
  • Refreshes scenario recordings and adds a replay-only polling-delay patch with cleanup coverage.
File Description
src/​edge-action/​DEVELOPMENT.md Documents playback-only polling-delay suppression and restoration.
src/​edge-action/​azext_edge_action/​tests/​latest/​test_edge_action.py Adds subscription-list membership checks, validation-status assertions, and the replay hook.
src/​edge-action/​azext_edge_action/​tests/​latest/​test_edge_action_recording_processors.py Verifies the polling patch is replay-only and restored after cleanup.
src/​edge-action/​azext_edge_action/​tests/​latest/​test_edge_action_custom.py Tests both listing scopes, exact requests, pagination, and CLI subscription overrides.
src/​edge-action/​azext_edge_action/​tests/​latest/​recordings/​test_edge_action_version_operations.yaml Refreshes version lifecycle recordings.
src/​edge-action/​azext_edge_action/​tests/​latest/​recordings/​test_edge_action_version_get_version_code.yaml Refreshes deployment and code-download recordings.
src/​edge-action/​azext_edge_action/​tests/​latest/​recordings/​test_edge_action_version_deploy_with_zip.yaml Refreshes ZIP deployment recordings.
src/​edge-action/​azext_edge_action/​tests/​latest/​recordings/​test_edge_action_version_deploy_with_file.yaml Refreshes file deployment recordings.
src/​edge-action/​azext_edge_action/​tests/​latest/​recordings/​test_edge_action_version_deploy_with_content.yaml Refreshes inline-content deployment recordings.
src/​edge-action/​azext_edge_action/​aaz/​latest/​edge_action/​_list.py Adds subscription-scoped listing and optional resource-group selection.

Review effort: Balanced

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@x-engineering-agent

Copy link
Copy Markdown

Hi Jean Kim (@kestry),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 9b969aa1-e83b-43e4-b2f4-04f3d3db2aab
@kestry Jean Kim (kestry) changed the title [Edge Action] Support subscription-scoped listing and strengthen playback coverage [Edge Action] Release 1.1.0 with subscription-scoped listing Oct 29, 2026
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@JaysonTaiMicrosoft
JaysonTaiMicrosoft merged commit bfd7c1c into Azure:main Oct 29, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ edge-action-1.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=188485391&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants