Repository navigation
[Edge Action] Release 1.1.0 with subscription-scoped listing - #10536
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the subscription-scoped listing change.
No open issues 🎉
What changed in this PR
Adds subscription-scoped listing to the Edge Action extension while preserving resource-group listing, stable API 2026-10-01, and pagination. Strengthens offline and scenario coverage without changing runtime dependencies or release metadata.
Changes:
- Makes
--resource-groupoptional and selects the corresponding list endpoint. - Expands checks for subscription overrides, pagination, response fields, and deployed-version validation status.
- Refreshes scenario recordings and adds a replay-only polling-delay patch with cleanup coverage.
| File | Description |
|---|---|
src/edge-action/DEVELOPMENT.md |
Documents playback-only polling-delay suppression and restoration. |
src/edge-action/azext_edge_action/tests/latest/test_edge_action.py |
Adds subscription-list membership checks, validation-status assertions, and the replay hook. |
src/edge-action/azext_edge_action/tests/latest/test_edge_action_recording_processors.py |
Verifies the polling patch is replay-only and restored after cleanup. |
src/edge-action/azext_edge_action/tests/latest/test_edge_action_custom.py |
Tests both listing scopes, exact requests, pagination, and CLI subscription overrides. |
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_version_operations.yaml |
Refreshes version lifecycle recordings. |
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_version_get_version_code.yaml |
Refreshes deployment and code-download recordings. |
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_version_deploy_with_zip.yaml |
Refreshes ZIP deployment recordings. |
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_version_deploy_with_file.yaml |
Refreshes file deployment recordings. |
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_version_deploy_with_content.yaml |
Refreshes inline-content deployment recordings. |
src/edge-action/azext_edge_action/aaz/latest/edge_action/_list.py |
Adds subscription-scoped listing and optional resource-group selection. |
Review effort: Balanced
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Hi Jean Kim (@kestry), |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b969aa1-e83b-43e4-b2f4-04f3d3db2aab
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ edge-action-1.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=188485391&view=results |
🤖 PR Validation —⚠️ Review suggested
Release Edge Action extension 1.1.0 with subscription-scoped listing.
az edge-action listnow lists resources in the selected subscription when--resource-groupis omitted; supplying the argument preserves resource-group-scoped listing. Both paths use stable API2026-10-01and retain pagination.Companion AAZ models: Azure/aaz#1146, targeting
main.Changes
--resource-groupoptional and adding the subscription-list operation/example.--max-items/--next-tokenbehavior with offline tests.--subscriptionoverrides the active subscription for both listing scopes.validationStatuson deployed versions before and after swapping the default; retain existing skips and stronger successful-deployment checks.AAZBasePolling._delaypatch with cleanup and a regression test proving it is absent from recording hooks and restored afterward.setup.pyfrom1.0.0to1.1.0and add the matchingHISTORY.rstrelease entry.Release and compatibility
This is a backward-compatible capability addition, so
1.1.0follows the documented minor-version increment rule. Existing successful resource-group-scoped invocations retain their scope; previously rejected invocations without a resource group can now list subscription-wide.The breaking-change checker flags removal of the argument's
required=Trueproperty (rule 1009). That is the intentional relaxation enabling the additional scope, not removal of the argument or its existing behavior. No new suppression is added.src/index.jsonis not modified; the normal extension publication pipeline handles the index update after merge.The extension-local replay hook skips AAZ polling delays only. The shared foreground-yield fix is separate in Azure/azure-cli#34300. The local validation environment includes that shared fix, so playback timing must not be attributed to this extension PR alone.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az edge-action list, with and without--resource-group, including explicit--subscriptionand pagination options.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)Validation for release-metadata commit
4dc425f125ca78b82e7f7445e95d3f76161bec59, with the virtual environment activated andAZURE_TEST_RUN_LIVEunset:The pre-push hook completed successfully and pushed the release commit. The user-approved rebase and
azdev setuprefreshed the separate editable Azure CLI environment before these checks. No live Azure operations were run, and the extension working tree was clean after the push. This default-parallel hook run is not an apples-to-apples timing comparison with earlier--seriesruns.Earlier validation at
0ee7544cfc72180982e5de3a2ecd1ee6797a3031also passed:The user separately reported eight live tests and eight playback tests passing before supplying the refreshed recordings. Those live runs were not performed by the agent. Current-release-head CI has not yet been assessed here; the bot-managed section above identifies its own evaluated commit.
For new extensions:
This updates an existing extension; its summary is unchanged.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.