Repository navigation
Network Fabric CLI command and example updates - v10.0.0b4 - #10538
Conversation
|
Thank you for your contribution idanielsteven! We will review the pull request and get back to you soon. |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
The release notes announce 10.0.0b4 while packaging still builds 10.0.0b3, and they reference an unregistered command name.
2 open issues
What changed in this PR
This PR extends the Managed Network Fabric Azure CLI extension with bootstrap-device and interface operations for the planned 10.0.0b4 release, while refreshing command help examples.
Changes:
- Adds four bootstrap-device commands and bootstrap-interface administrative-state updates, with playback fixtures and tests.
- Updates custom-operation imports and error-handler returns, and exposes bootstrap-interface serial numbers.
- Standardizes help examples and reorganizes network-monitor argument groups.
Paths are relative to src/managednetworkfabric/.
| File | Description |
|---|---|
HISTORY.rst |
Documents the planned b4 release. |
azext_managednetworkfabric/tests/unit/test_custom_commands.py |
Updates imports and adds password-resync wrapper tests. |
azext_managednetworkfabric/tests/latest/test_bootstrapinterface_update_admin_state.py |
Tests interface administrative-state updates. |
azext_managednetworkfabric/tests/latest/test_bootstrapdevice_update_admin_state.py |
Tests device administrative-state updates. |
azext_managednetworkfabric/tests/latest/test_bootstrapdevice_resync_password.py |
Tests device password resynchronization. |
azext_managednetworkfabric/tests/latest/test_bootstrapdevice_refresh_configuration.py |
Tests device configuration refresh. |
azext_managednetworkfabric/tests/latest/test_bootstrapdevice_reboot.py |
Tests device reboot. |
azext_managednetworkfabric/tests/latest/recordings/test_GA_bootstrapinterface_update_admin_state_scenario1.yaml |
Adds synthetic interface-state playback responses. |
azext_managednetworkfabric/tests/latest/recordings/test_GA_bootstrapdevice_update_admin_state_scenario1.yaml |
Adds synthetic device-state playback responses. |
azext_managednetworkfabric/tests/latest/recordings/test_GA_bootstrapdevice_resync_password_scenario1.yaml |
Adds synthetic password-resync playback responses. |
azext_managednetworkfabric/tests/latest/recordings/test_GA_bootstrapdevice_refresh_configuration_scenario1.yaml |
Adds synthetic configuration-refresh playback responses. |
azext_managednetworkfabric/tests/latest/recordings/test_GA_bootstrapdevice_reboot_scenario1.yaml |
Adds synthetic reboot playback responses. |
azext_managednetworkfabric/tests/latest/config.ini |
Adds administrative-state test inputs. |
azext_managednetworkfabric/operations/fabric_rotate_certificate.py |
Returns the error-formatting helper result. |
azext_managednetworkfabric/operations/fabric_resync_password.py |
Returns the error-formatting helper result. |
azext_managednetworkfabric/operations/device_resync_password.py |
Returns the error-formatting helper result. |
azext_managednetworkfabric/operations/bootstrapdevice_resync_password.py |
Adds custom password-resync error formatting. |
azext_managednetworkfabric/custom/__init__.py |
Removes the legacy custom-module loader. |
azext_managednetworkfabric/commands.py |
Updates operation imports and registers the new wrapper. |
azext_managednetworkfabric/aaz/latest/networkfabric/taprule/_create.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/routepolicy/_create.py |
Clarifies example descriptions. |
azext_managednetworkfabric/aaz/latest/networkfabric/networkmonitor/_update.py |
Refreshes the example and regroups tags. |
azext_managednetworkfabric/aaz/latest/networkfabric/networkmonitor/_show.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/networkmonitor/_delete.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/networkmonitor/_create.py |
Refreshes the example and regroups resource arguments. |
azext_managednetworkfabric/aaz/latest/networkfabric/l2domain/_update.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/l2domain/_create.py |
Standardizes example quoting and spacing. |
azext_managednetworkfabric/aaz/latest/networkfabric/ipprefix/_update.py |
Uses the full resource-group option in help. |
azext_managednetworkfabric/aaz/latest/networkfabric/internalnetwork/_update.py |
Standardizes example quoting and spacing. |
azext_managednetworkfabric/aaz/latest/networkfabric/internalnetwork/_create.py |
Standardizes example quoting and spacing. |
azext_managednetworkfabric/aaz/latest/networkfabric/interface/_update.py |
Uses the full resource-group option in help. |
azext_managednetworkfabric/aaz/latest/networkfabric/interface/_update_admin_state.py |
Uses the full resource-group option in help. |
azext_managednetworkfabric/aaz/latest/networkfabric/interface/_show.py |
Uses the full resource-group option in help. |
azext_managednetworkfabric/aaz/latest/networkfabric/interface/_list.py |
Uses the full resource-group option in help. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_view_device_configuration.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_validate_configuration.py |
Uses the full resource-group option in help. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_upgrade.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_update.py |
Standardizes quoting in both examples. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_rotate_password.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_rotate_certificate.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_resync_password.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_resync_certificate.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_lock_fabric.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_discard_commit_batch.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_create.py |
Standardizes quoting in both examples. |
azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_commit_batch_status.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/device/_upgrade.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/device/_resync_password.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/device/_resync_certificate.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/device/_refresh_configuration.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/device/_reboot.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/controller/_create.py |
Standardizes example quoting and spacing. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_wait.py |
Adds serial-number response handling. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_update_admin_state.py |
Adds the interface administrative-state command. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_show.py |
Adds serial-number output and refreshes help. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/_list.py |
Adds serial-number output and corrects examples. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapinterface/__init__.py |
Exports the new administrative-state command. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_update_admin_state.py |
Adds the device administrative-state command. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_show.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_resync_password.py |
Adds the device password-resync command. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_refresh_configuration.py |
Adds the device configuration-refresh command. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_reboot.py |
Adds the device reboot command. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/_list.py |
Standardizes example quoting. |
azext_managednetworkfabric/aaz/latest/networkfabric/bootstrapdevice/__init__.py |
Exports the four new device commands. |
azext_managednetworkfabric/aaz/latest/networkfabric/acl/_update.py |
Standardizes example options and spacing. |
azext_managednetworkfabric/__init__.py |
Points custom-command resolution to operations. |
Review effort: Balanced
|
Adding mansoor sarfraz (@msarfraz) to help review |
|
idanielsteven No confirmed code findings in the changed Network Fabric commands. Author-provided scenarios and sanitized recordings for all five bootstrap actions include polling, terminal successful responses, and assertions for operation output and resource state. Their live-execution provenance and independent REST-spec conformance were not verified; the source helper did not permit access to the REST-spec repository. Review detailsUpstream CI23 checks completed: 22 passed, none failed or pending. Test validation
Risk assessment100/100 · Critical The Critical rating is driven by security-sensitive behavior, public CLI behavior, dependency or supply chain and 2 additional signal(s).
Ask the Agent Tick a box to queue an action. Requires write access to this repository.
|
mansoor sarfraz (msarfraz)
left a comment
There was a problem hiding this comment.
Thanks for addressing the review feedback. The latest changes include completion-status and resource read-back assertions for the five affected action scenarios, which address the immediate concerns for this PR.
I’m comfortable deferring broader standardization of completion/output assertions across the remaining tests to a separate PR, as proposed. Please link a tracking issue or follow-up PR here and capture the planned delivery with the next API/CLI release.
No further blocking concerns from my side. Approved, with the broader test improvements tracked separately.
There was a problem hiding this comment.
idanielsteven Ready for human review. See the X Engineering Agent Report.
|
[Release] Update index.json for extension [ managednetworkfabric-10.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=190960744&view=results |


🤖 PR Validation —⚠️ Review suggested
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
6 added suppressions
src/managednetworkfabric/azext_managednetworkfabric/operations/bootstrapdevice_resync_password.py# pylint: disable=protected-access,duplicate-codesrc/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapdevice_reboot.py# pylint: disable=too-few-public-methods,unnecessary-pass,unused-argumentsrc/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapdevice_refresh_config.py# pylint: disable=too-few-public-methods,unnecessary-pass,unused-argumentsrc/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapdevice_resync_password.py# pylint: disable=too-few-public-methods,unnecessary-pass,unused-argumentsrc/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapdevice_update_admin_state.py# pylint: disable=too-few-public-methods,unnecessary-pass,unused-argumentsrc/managednetworkfabric/azext_managednetworkfabric/tests/latest/test_bootstrapinterface_update_admin_state.py# pylint: disable=too-few-public-methods,unnecessary-pass,unused-argumentNetwork Fabric CLI command and example updates - v10.0.0b4
aaz: Azure/aaz#1147
10.0.0b4
++++++++
bootstrapdevice:rebootrefresh-configresync-passwordupdate-admin-stateupdate-admin-statefor command groupbootstrapinterface.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.