Skip to content

[agentfabric] Migrate all commands to November preview API - #10548

Merged
Naga Nandyala (naga-nandyala) merged 2 commits into
Azure:mainfrom
kmurudi:agentfabric-november-api-fresh
Nov 11, 2026
Merged

Naga Nandyala (naga-nandyala) merged 2 commits into
Azure:mainfrom
kmurudi:agentfabric-november-api-fresh

Conversation

@kmurudi

@kmurudi Kshitija Murudi (kmurudi) commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Suppressions
⚠️ None ️✔️ None
⚠️Azure CLI Extensions Breaking Change Test
⚠️agentfabric
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd agentfabric aks attach cmd agentfabric aks attach added parameter if_none_match

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az agentfabric, az agentfabric aks, az agentfabric member, az agentfabric egress-trust-bundle, and az agentfabric policy-group: all 19 API commands and four waits.

Dependency: Azure/aaz#1155, commit 27059f6d46d9af223bffe83df8b574bc16a8e6ca. The November FQDN example was corrected in AAZ first, then regenerated here; historical model versions remain unchanged.

Freshly generated from main d79d5bc724e7701a03ad7a74c064d06c260ad417, without copying/cherry-picking the superseded implementation or closed #10547. Ready for review; merge and release remain subject to normal repository approval.

Source: RPSaaSMaster 7383c939bca038e922edf44005ac136fc35c9913, specification/networksecurity/resource-manager/Microsoft.NetworkSecurity/agentFabric/preview/2026-11-03-preview/agentFabric.json, SHA-256 16408571bc0f993954ac764851256b524571ca4db16f0c13b1cef3047f53ddc1.

Changes:

  • Generate all existing operations/waits against 2026-11-03-preview, preserving aliases. Generate the read-only member wait from its show model because automatic AAZ waits require a mutating LRO.
  • Add MCP matching, TLS Inspect/Bypass rules, optional rule actions, 3–256 character resource names, and conditional AKS attach.
  • Preserve member response variants and read-only commands, tags-only Policy Group PATCH, and custom AKS GET-then-PATCH behavior. Update extension to 1.0.0b2; src/index.json and custom.py are unchanged.
  • Refresh all six resource-scenario cassettes from real November service calls in westcentralus; remove October/November compatibility matching. Playback now requires exact resource API versions. Service-issued polling URLs are followed unchanged and can use a different operation-status API version.

Jayson Tai feedback from #10370

Reviewed all ten JaysonTaiMicrosoft entries: five substantive comments, one /azp run, and four empty review submissions including approval.

Feedback Coverage
Sync main / CI Started from refreshed main. Integration failures came from a test assuming runtime regex enforcement removed in current CLI core; the fixed test checks exact generated schema limits. Current head passes CI, including linter/style and all Python 3.10–3.14 integration/build jobs.
Scenario tests for every command All 19 API commands and four waits occur in scenarios. Six fresh cassettes cover Fabric, Policy Group, AKS, positive existing-member reads, and both egress reads. Generated FQDN/MCP/TLS examples, omitted URL action, and conditional attach are also recorded.
Skipped scenarios / markers No unconditional skips or live-only coverage gaps; full playback has zero skipped tests. Member/egress live tests skip only when documented existing-resource environment variables are missing; both were supplied for recording.
Egress 404 / deployment and GA Fresh November LIST/SHOW returned 200 with the default bundle and nonempty certificates. This demonstrates a deployed preview in westcentralus, not GA/all-region availability.
AKS 404s / full lifecycle Fresh Entra-enabled attach/show/list/Standard-to-Premium update/waits/detach and deletion passed. The 80-interaction cassette has exactly three expected 404 GETs: pre-create cluster absence and post-delete association/Fabric absence. Tests enforce those semantics. Cleanup waits for AKS's post-detach update before deleting it.
AAZ/member consistency Companion Azure/aaz#1155 and this PR have the same 19 API commands; member remains show/list plus generated wait. Both PRs are cross-linked, and the FQDN correction is regenerated from the updated source model commit.

Fresh recording evidence

All six resource scenarios passed live using CLI 2.91.0 in westcentralus. Existing resources were used only for member/egress reads; the existing AKS/Fabric enrollment stayed Succeeded/Premium. All six disposable test groups from successful/retried runs and both temporary AKS node groups were confirmed absent. No Content Safety credentials or inspection profiles were supplied.

Two unsuccessful attempts were preserved outside the PR: an invalid legacy FQDN selector and an AKS delete racing a post-detach update. Both causes were fixed and the scenarios re-recorded successfully; neither failed trace was relabeled as successful.

Validation for 635bf7d001fd1158237b2ebd7e749a88d02e3faf (session-local launchers use the CLI-bundled Python and standard SDK; live mode journals resources without altering responses):

  • record_live.py src\agentfabric\azext_agentfabric\tests\latest\test_agentfabric_scenario.py -k 'AgentfabricResourceScenario and not aks_lifecycle' -q --disable-warnings: initial run 4 passed, 1 failed on the FQDN example; failed fixture excluded.
  • record_live.py src\agentfabric\azext_agentfabric\tests\latest\test_agentfabric_scenario.py -k test_agentfabric_policy_group_lifecycle -q --disable-warnings: passed after AAZ correction, including all policy examples.
  • record_live.py src\agentfabric\azext_agentfabric\tests\latest\test_agentfabric_scenario.py -k test_agentfabric_aks_lifecycle -q --disable-warnings: passed after teardown synchronization, including deletion.
  • review_current_cli_tests.py src\agentfabric\azext_agentfabric\tests\latest -q --disable-warnings: 28 passed, 215 subtests passed, zero skipped, on Azure CLI 2.91.0; strict API matching, resource versions, waits, payloads, response variants, boundaries, and absence checks included.
  • python -m azdev style agentfabric: passed, pylint and flake8.
  • python -m azdev scan -d src\agentfabric -r --include '*.py' '*.yaml' '*.md' '*.rst' --query secrets_detected -o tsv: passed, false; pre-commit scan also passed.
  • python scripts\ci\test_index.py -q: passed, 9 run, 2 skipped.
  • git diff --check: passed.

A wheel built from current head 635bf7d0 was installed in isolation with Azure CLI 2.91.0. All 44 installed Python files matched the wheel; all five command groups and all 23 command help surfaces passed, including the corrected FQDN and November MCP/TLS examples. SHA-256: b9651d90075698c94d5633fe757f186098f7124857e381f0f6834befe25df2c8. Local azdev linter was previously environment-blocked during initialization (NoneType command-string error); the current head passes GitHub linter/style and Azure Pipelines integration/build tests for Python 3.10, 3.11, 3.12, 3.13, and 3.14, plus policy, index, credential, and breaking-change jobs. The optional skip-version-cal job is skipped as expected. The automated parameter-addition warning above reflects the intentional optional --if-none-match addition.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

Not applicable: this updates an existing extension.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Generate from Azure/aaz 4d8880d2 and refreshed RPSaaSMaster 7383c939. Retain all existing commands and waits, add nested policy and response coverage, and document the historical playback limitation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 2, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for your contribution Kshitija Murudi (@kmurudi)! We will review the pull request and get back to you soon.

Capture genuine November Fabric, Policy Group, member, egress, and AKS lifecycles with strict API matching. Wait for AKS teardown updates before deletion, align the FQDN example with AAZ models, and make schema boundary tests independent of CLI runtime regex enforcement.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kmurudi
Kshitija Murudi (kmurudi) marked this pull request as ready for review November 2, 2026 21:41
Copilot AI balanced review requested due to automatic review settings November 2, 2026 21:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Agent Fabric CLI November API migration.

No open issues 🎉

What changed in this PR

Migrates the existing Agent Fabric CLI extension to 2026-11-03-preview, aligning all 19 API commands and four waits with the November contract while preserving aliases and custom AKS update behavior.

Changes:

  • Adds MCP matching conditions, TLS inspection rules, optional rule actions, longer resource names, and conditional AKS attachment.
  • Expands member response schemas and regression coverage, including strict API-version matching and synchronized AKS cleanup.
  • Updates documentation, refreshes service recordings, and bumps the extension to 1.0.0b2.
File Description
src/​agentfabric/​setup.py Bumps the extension version to 1.0.0b2.
src/​agentfabric/​README.md Documents the November contract, features, and validation scope.
src/​agentfabric/​HISTORY.rst Adds release notes for the migration.
src/​agentfabric/​azext_agentfabric/​tests/​latest/​test_agentfabric.py Tests API versions, payloads, response variants, and name limits.
src/​agentfabric/​azext_agentfabric/​tests/​latest/​test_agentfabric_scenario.py Adds policy examples, recording checks, and AKS cleanup synchronization.
src/​agentfabric/​azext_agentfabric/​tests/​latest/​recordings/​test_agentfabric_member_read.yaml Refreshes member reads with November AKS workload responses.
src/​agentfabric/​azext_agentfabric/​tests/​latest/​recordings/​test_agentfabric_egress_trust_bundle_list.yaml Refreshes trust-bundle list and show responses.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​policy_group/​_wait.py Updates polling API, name limits, and policy response fields.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​policy_group/​_update.py Updates API and response schemas while retaining tags-only PATCH.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​policy_group/​_show.py Adds November MCP and TLS response fields.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​policy_group/​_list.py Updates both list operations and policy response schemas.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​policy_group/​_delete.py Updates the deletion API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​policy_group/​_create.py Adds MCP matching, TLS rules, optional actions, and examples.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​member/​_wait.py Updates polling and models ACI, AKS, and sandbox workloads.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​member/​_show.py Expands member workload responses and updates API metadata.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​member/​_list.py Expands listed member workload responses.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​egress_trust_bundle/​_show.py Updates the singleton-read API and parent name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​egress_trust_bundle/​_list.py Updates the collection-read API and parent name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​aks/​_wait.py Updates association polling API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​aks/​_update.py Makes the target ID optional in the generated PATCH schema.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​aks/​_show.py Updates association-read API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​aks/​_list.py Updates association-list API and parent name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​aks/​_detach.py Updates detachment API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​aks/​_attach.py Adds optional If-None-Match header support.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​_wait.py Updates Fabric polling API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​_update.py Updates Fabric PATCH API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​_show.py Updates Fabric-read API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​_list.py Updates resource-group and subscription list APIs.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​_delete.py Updates Fabric deletion API and name limits.
src/​agentfabric/​azext_agentfabric/​aaz/​latest/​agentfabric/​_create.py Updates Fabric creation API and name limits.

Review effort: Balanced

@yonzhan

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@naga-nandyala
Naga Nandyala (naga-nandyala) merged commit 3a1df96 into Azure:main Nov 11, 2026
24 checks passed
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ agentfabric-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=190562433&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants