Skip to content

{CI} Suppress CredScan false positives in regression tests - #10560

Merged
Naga Nandyala (naga-nandyala) merged 1 commit into
mainfrom
ci/suppress-test-fixture-credscan
Nov 5, 2026
Merged

Naga Nandyala (naga-nandyala) merged 1 commit into
mainfrom
ci/suppress-test-fixture-credscan

Conversation

@naga-nandyala

@naga-nandyala Naga Nandyala (naga-nandyala) commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Suppressions
️✔️ None ⚠️ 10 added

This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.

10 added suppressions
File Line Kind Code
scripts/ci/credscan/CredScanSuppressions.json 352 credential scan "file": [
scripts/ci/credscan/CredScanSuppressions.json 353 credential scan "src\logicapp\azext_logicapp\tests\latest\test_offline_commands.py"
scripts/ci/credscan/CredScanSuppressions.json 355 credential scan "_justification": "[LogicApps] Synthetic connection strings used by offline tests for secret handling and deployment pa…
scripts/ci/credscan/CredScanSuppressions.json 358 credential scan "file": [
scripts/ci/credscan/CredScanSuppressions.json 359 credential scan "src\validate\azext_validate\tests\latest\test_validate_safety.py",
scripts/ci/credscan/CredScanSuppressions.json 360 credential scan "src\validate\azext_validate\tests\latest\test_validate_shell.py"
scripts/ci/credscan/CredScanSuppressions.json 362 credential scan "_justification": "[Validate] Dummy secrets used by tests that verify command values are not echoed in validation error…
scripts/ci/credscan/CredScanSuppressions.json 365 credential scan "file": [
scripts/ci/credscan/CredScanSuppressions.json 366 credential scan "src\vm-repair\azext_vm_repair\tests\latest\test_command_injection.py"
scripts/ci/credscan/CredScanSuppressions.json 368 credential scan "_justification": "[VM Repair] Dummy passwords used by mocked command-injection regression tests; not live credentials."

Summary

Suppress all seven CSCAN-GENERAL0060 false positives blocking default-branch CI in run 20261105.12.

Add three justified, file-scoped entries to the existing CredScan suppression configuration:

  • Logic Apps: synthetic connection strings in offline secret-handling and deployment-package exclusion tests (2 findings).
  • Validate: dummy secrets verifying validation errors do not echo command values (2 findings).
  • VM Repair: dummy passwords in mocked command-injection regression tests (3 findings).

These fixtures were introduced by #10467, #10461, and #10443 respectively. This follows the file-based false-positive suppression precedent in #10460 and #9692. Only the four named test files are excluded; production code, test behavior, the scanner, and its failure threshold are unchanged. All 39 existing suppression entries are preserved.

Validation

  • Parsed the suppression configuration as JSON.
  • Verified all existing entries remain unchanged and all four added paths are tracked test files.
  • Verified the added entries cover all seven findings from build 370814's timeline.
  • git diff --check passed.
  • CredScan is not available locally; pipeline validation is required. No extension code, package metadata, or index changes.

Add file-scoped suppressions for synthetic Logic Apps, Validate and VM Repair test credentials, following existing test-fixture suppressions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@yonzhan

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@naga-nandyala
Naga Nandyala (naga-nandyala) merged commit 411fe7d into main Nov 5, 2026
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants