Skip to content

Deprecate clustermeshprofile commands and replace them with network cross-cluster - #10561

Open
David Vadas (dvadas) wants to merge 7 commits into
Azure:mainfrom
dvadas:fleet-network-cross-cluster
Open

David Vadas (dvadas) wants to merge 7 commits into
Azure:mainfrom
dvadas:fleet-network-cross-cluster

Conversation

@dvadas

@dvadas David Vadas (dvadas) commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Suppressions
⚠️ None ⚠️ 4 added
⚠️Azure CLI Extensions Breaking Change Test
⚠️fleet
rule cmd_name rule_message suggest_message
⚠️ 1013 - SubgroupPropAdd fleet clustermeshprofile sub group fleet clustermeshprofile added property deprecate_info_redirect
⚠️ 1013 - SubgroupPropAdd fleet clustermeshprofile sub group fleet clustermeshprofile added property deprecate_info_target
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile apply cmd fleet clustermeshprofile apply removed property is_preview
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile create cmd fleet clustermeshprofile create removed property is_preview
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile delete cmd fleet clustermeshprofile delete removed property is_preview
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile list cmd fleet clustermeshprofile list removed property is_preview
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile list-members cmd fleet clustermeshprofile list-members removed property is_preview
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile show cmd fleet clustermeshprofile show removed property is_preview
⚠️ 1004 - CmdPropRemove fleet clustermeshprofile wait cmd fleet clustermeshprofile wait removed property is_preview
⚠️ 1004 - CmdPropRemove fleet gate approve cmd fleet gate approve removed property is_preview
⚠️ 1004 - CmdPropRemove fleet gate list cmd fleet gate list removed property is_preview
⚠️ 1004 - CmdPropRemove fleet gate show cmd fleet gate show removed property is_preview
⚠️ 1004 - CmdPropRemove fleet gate update cmd fleet gate update removed property is_preview
⚠️ 1011 - SubgroupAdd fleet network sub group fleet network added

This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.

4 added suppressions
File Line Kind Code
src/fleet/azext_fleet/custom.py 1299 pylint def show_cross_cluster_network(cmd, # pylint: disable=unused-argument
src/fleet/azext_fleet/custom.py 1307 pylint def list_cross_cluster_networks(cmd, # pylint: disable=unused-argument
src/fleet/azext_fleet/custom.py 1314 pylint def delete_cross_cluster_network(cmd, # pylint: disable=unused-argument
src/fleet/azext_fleet/custom.py 1337 pylint client, # pylint: disable=unused-argument

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az fleet

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 08:28
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the cross-cluster command migration.

No open issues 🎉

What changed in this PR

Introduces az fleet network cross-cluster as the replacement for az fleet clustermeshprofile, retaining the existing command path for compatibility.

Changes:

  • Registers the new command group and a deprecation notice redirecting users from the old group.
  • Renames custom handlers, shares argument definitions between both groups, and adds help for the new commands.
  • Updates the end-to-end scenario to use the new commands while retaining coverage of the legacy create command.
File Description
src/​fleet/​azext_fleet/​tests/​latest/​test_cross_cluster_network_scenario.py Migrates the scenario to the new command path and retains a legacy create call.
src/​fleet/​azext_fleet/​custom.py Renames handlers to cross-cluster network terminology.
src/​fleet/​azext_fleet/​commands.py Registers both command groups with shared handlers.
src/​fleet/​azext_fleet/​_params.py Shares argument definitions across both command groups.
src/​fleet/​azext_fleet/​_help.py Adds descriptions and examples for the new commands.
src/​fleet/​azext_fleet/​_breaking_change.py Registers the legacy command group's deprecation and replacement.

Review effort: Balanced

@x-engineering-agent

Copy link
Copy Markdown

Hi David Vadas (@dvadas),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@yonzhan

Copy link
Copy Markdown
Collaborator

Please fix CI issues

@naga-nandyala

Copy link
Copy Markdown
Contributor

Please fix CI failures

@naga-nandyala

Copy link
Copy Markdown
Contributor

There is re-work needed moving this to next milestone (Dec 2026)

@dvadas
David Vadas (dvadas) force-pushed the fleet-network-cross-cluster branch from 66fcfde to a053152 Compare November 16, 2026 08:36
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@yonzhan
Yong Zhang (yonzhan) requested a review from a team November 16, 2026 11:35
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@dvadas
David Vadas (dvadas) force-pushed the fleet-network-cross-cluster branch from 7ac8731 to 31129b6 Compare November 17, 2026 00:17
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@dvadas

Copy link
Copy Markdown
Member Author

I've fixed the issues with this PR and it should be ready to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants