Repository navigation
Deprecate clustermeshprofile commands and replace them with network cross-cluster - #10561
David Vadas (dvadas) wants to merge 7 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the cross-cluster command migration.
No open issues 🎉
What changed in this PR
Introduces az fleet network cross-cluster as the replacement for az fleet clustermeshprofile, retaining the existing command path for compatibility.
Changes:
- Registers the new command group and a deprecation notice redirecting users from the old group.
- Renames custom handlers, shares argument definitions between both groups, and adds help for the new commands.
- Updates the end-to-end scenario to use the new commands while retaining coverage of the legacy create command.
| File | Description |
|---|---|
src/fleet/azext_fleet/tests/latest/test_cross_cluster_network_scenario.py |
Migrates the scenario to the new command path and retains a legacy create call. |
src/fleet/azext_fleet/custom.py |
Renames handlers to cross-cluster network terminology. |
src/fleet/azext_fleet/commands.py |
Registers both command groups with shared handlers. |
src/fleet/azext_fleet/_params.py |
Shares argument definitions across both command groups. |
src/fleet/azext_fleet/_help.py |
Adds descriptions and examples for the new commands. |
src/fleet/azext_fleet/_breaking_change.py |
Registers the legacy command group's deprecation and replacement. |
Review effort: Balanced
|
Hi David Vadas (@dvadas), |
|
Please fix CI issues |
|
Please fix CI failures |
|
There is re-work needed moving this to next milestone (Dec 2026) |
66fcfde to
a053152
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
7ac8731 to
31129b6
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
I've fixed the issues with this PR and it should be ready to go now. |
🤖 PR Validation —⚠️ Review suggested
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
4 added suppressions
src/fleet/azext_fleet/custom.pydef show_cross_cluster_network(cmd, # pylint: disable=unused-argumentsrc/fleet/azext_fleet/custom.pydef list_cross_cluster_networks(cmd, # pylint: disable=unused-argumentsrc/fleet/azext_fleet/custom.pydef delete_cross_cluster_network(cmd, # pylint: disable=unused-argumentsrc/fleet/azext_fleet/custom.pyclient, # pylint: disable=unused-argumentThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az fleet
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.