Repository navigation
fix: Update token budget limits - Microsoft.AIInfraOptimization - #10580
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
The command tests lack regression coverage for both token fields above the old 131072 ceiling, including acceptance at the new upper boundary and rejection above it.
1 open issue
What changed in this PR
Updates argument validation for az aiinfraoptimization recommendvmsku to match the token-budget limits in the linked AAZ change.
Changes:
- Raises the maximum for both token-budget fields from 131072 to 2147483647, retaining a minimum of zero.
- Changes the help example’s model parameter count to 70 billion.
| File | Description |
|---|---|
src/aiinfraoptimization/azext_aiinfraoptimization/aaz/latest/aiinfraoptimization/_recommendvmsku.py |
Increases token argument limits and adjusts the documented example. |
Review effort: Balanced
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
ba8a94a to
dce9f73
Compare
|
Kunal Karmakar (@kkarmakarMS) No confirmed changed-line defects found. Both token limits expand consistently, request serialization preserves their values, and the release history matches version Review detailsUpstream CIThe supplied snapshot has six completed checks, five passed and zero failures, with none pending. Test validation
Manual inspection supplements that automated coverage classification. Under The recording does not establish service enforcement of the combined-token ceiling or model-context bound. Suggested focused scenario in All six changed files were inspected. Framework implementation under Risk assessment75/100 · Critical The Critical rating is driven by security-sensitive behavior, public CLI behavior, dependency or supply chain and 1 additional signal(s).
Ask the Agent Tick a box to queue an action. Requires write access to this repository.
|
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
19674ea to
77473b5
Compare
|
Aditya Pujara (@a0x1ab) please could you execute |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
683e684 to
2eb3807
Compare
|
Aditya Pujara (@a0x1ab) please could you execute |
There was a problem hiding this comment.
Kunal Karmakar (@kkarmakarMS) Ready for human review. See the X Engineering Agent Report.
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
xuming-ms CI tests are clean, please could you approve this and the associated aaz PR ? |
|
[Release] Update index.json for extension [ aiinfraoptimization-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=192163046&view=results |

🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aiinfraoptimizationAAZ PR: Azure/aaz#1165
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.