Repository navigation
{Repository} Add evidence-based pull request review instructions - #10599
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 50c27eca-5a83-4d75-85a7-d76fdc1cb00d
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the new repository-wide Azure CLI extension review guidance.
No open issues 🎉
What changed in this PR
Adds a repository-wide code-review baseline for Azure CLI extensions, excluding the cloud agent. The guidance draws on ten merged PRs to promote evidence-based reviews without changing commands or extension releases.
Changes:
- Defines checks for validation evidence, compatibility, release consistency, and generated AAZ model synchronization.
- Sets expectations for behavioral tests, recording sanitization, and reproducible test prerequisites.
- Covers CI safety and revalidation of earlier findings while respecting valid index-only releases and accepted follow-ups.
| File | Description |
|---|---|
.github/instructions/pr-review.instructions.md |
Adds review guidance covering evidence, compatibility, releases, generated code, tests, and CI safety. |
Review effort: Balanced
xuming-ms
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Generated a pr review skill based on the scrum master loop doc and various docs in cli repo.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Not applicable: review-agent instructions only; no
azcommands or extension releases change.Description
Add
.github/instructions/pr-review.instructions.mdas a repository-wide code-review baseline, excluding the cloud agent.The instructions cover release/version consistency, breaking-change policy, generated AAZ model synchronization, meaningful tests, and CI/release safety. They incorporate a qualitative review of five merged PRs from 2026 (#10473, #10537, #10530, #10581, #10593) and five from 2025 (#8601, #9286, #9344, #9476, #9479):
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)Not run: not applicable; this PR changes only Markdown instructions, not extension code.
python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)Not run: not applicable; neither
src/index.jsonnor extension packaging changes.Not applicable: no extension release or version change.
For new extensions:
Not applicable: no new extension.
Validation:
git diff --cached --checkpassed. Manually reviewed the instructions against the ten-PR sample and linked policies. No runtime tests or fresh-session agent evaluation were run.Local pre-commit and pre-push hook checks did not run: both reported
Python not found in PATH. The commit and push completed.About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.