Repository navigation
[HorizonDB] Add system-managed pool maintenance information - #10602
Open
Matthew Boentoro (mattboentoro) wants to merge 4 commits into
Open
Matthew Boentoro (mattboentoro) wants to merge 4 commits into
Matthew Boentoro (mattboentoro) wants to merge 4 commits into
Conversation
Return the portal's system-managed maintenance notice from pool maintenance-event list without issuing an API request. Keep maintenance-event show hidden, document the behavior, and prepare version 1.0.0b10. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc5bd08e-335e-4241-8a98-9e6f8ebab442
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The maintenance-event override lacks offline regression tests, and the missing Azure/aaz model PR leaves generated command and API-version alignment unverified.
2 open issues
What changed in this PR
Adds system-managed maintenance information to the HorizonDB extension through az horizondb cluster pool maintenance-event list, without calling the maintenance-event API.
Changes:
- Adds an informational list override with filtering and pagination disabled, plus a hidden
showcommand. - Updates command-group metadata and custom-command imports.
- Documents the maintenance policy and prepares release
1.0.0b10.
| File | Description |
|---|---|
src/horizondb/setup.py |
Bumps version to 1.0.0b10. |
src/horizondb/README.md |
Documents the maintenance information command. |
src/horizondb/HISTORY.rst |
Adds maintenance release notes. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/private_link_resource/__init__.py |
Imports existing custom commands. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/maintenance_event/custom.py |
Returns maintenance information without service requests. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/maintenance_event/_show.py |
Adds hidden maintenance-event retrieval. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/maintenance_event/_list.py |
Adds the generated list command underlying the override. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/maintenance_event/__init__.py |
Exports generated maintenance commands. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/maintenance_event/__cmd_group.py |
Registers the maintenance-event group. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/__init__.py |
Imports existing pool customizations. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/__cmd_group.py |
Revises pool help and removes its preview flag. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/__init__.py |
Imports cluster and restore customizations. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/__cmd_group.py |
Revises cluster help and removes its preview flag. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/__cmd_group.py |
Revises root help and removes its preview flag. |
src/horizondb/azext_horizondb/__init__.py |
Registers the informational list override. |
Review effort: Balanced
nasc17
reviewed
Nov 18, 2026
nasc17
left a comment
Member
There was a problem hiding this comment.
Please review updates that went into files not part of this scope and add a test recording.
Member
Author
|
Companion AAZ command-model PR: Azure/aaz#1173 |
Ref: Azure#10602 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc5bd08e-335e-4241-8a98-9e6f8ebab442
Restore the original parent summaries and preview flags, remove unrelated custom wildcard imports, and keep new maintenance commands in Preview. Native regeneration against the companion AAZ models matches the command arguments, operations, API versions, and group metadata, excluding the intentional hidden-show override. Ref: Azure#10602 (comment) Ref: Azure#10602 (comment) Ref: Azure#10602 (comment) Ref: Azure#10602 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc5bd08e-335e-4241-8a98-9e6f8ebab442
Exercise the registered CLI list path with HTTP client creation and network requests blocked. Cover exact JSON/TSV output, hidden filtering/pagination options, and hidden show in group help. No service recording is needed for an offline informational command. Ref: Azure#10602 (comment) Ref: Azure#10602 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc5bd08e-335e-4241-8a98-9e6f8ebab442
Matthew Boentoro (mattboentoro)
pushed a commit
to mattboentoro/aaz
that referenced
this pull request
Nov 18, 2026
Keep the new maintenance commands in Preview and retain the existing HorizonDB, cluster, and pool summaries. Ref: Azure/azure-cli-extensions#10602 (comment) Ref: Azure/azure-cli-extensions#10602 (comment) Ref: Azure/azure-cli-extensions#10602 (comment) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cc5bd08e-335e-4241-8a98-9e6f8ebab442
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
nasc17
reviewed
Nov 19, 2026
| is_preview=True, | ||
| ) | ||
| class List(AAZCommand): | ||
| """List maintenance events for a HorizonDB pool. Use the OData $filter query parameter to filter by properties/status with the eq and or operators. For example, properties/status eq 'Planned' or properties/status eq 'InProgress' returns upcoming events. |
Member
There was a problem hiding this comment.
This description needs to be changes from the AAZ tool. "List maintenance events for a HorizonDB pool."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤖 PR Validation —⚠️ Review suggested
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
1 added suppression
src/horizondb/azext_horizondb/aaz/latest/horizondb/cluster/pool/maintenance_event/custom.pyargs_schema.filter._registered = False # pylint: disable=protected-accessThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az horizondb cluster pool maintenance-event listaz horizondb cluster pool maintenance-event show(hidden)Summary
listresponse matching the portal, without calling the maintenance-event API. Hide inapplicable filtering and pagination options. See custom.py:11-41.showhidden. See _show.py:14-17.1.0.0b10with release notes. See README.md:189-196, setup.py:17, and HISTORY.rst:6-11.The informational response is:
Validation
Commands were run from the repository root using the existing development environment. The wheel build used a temporary
$wheelDir..\env\Scripts\python.exe -m azdev style horizondb.\env\Scripts\python.exe .\scripts\ci\test_index.py -q.\env\Scripts\python.exe -m azdev test --series azext_horizondb.\env\Scripts\python.exe -m build --wheel --no-isolation --outdir $wheelDir .\src\horizondbhorizondb-1.0.0b10-py2.py3-none-any.whl. Wheel inspection confirmed the version, matching release notes, and inclusion of the custom maintenance command..\env\Scripts\python.exe -m azure.cli horizondb cluster pool maintenance-event list -g example-resource-group --cluster-name example-cluster --pool-name example-pool --output tsvAdditional in-process CLI assertions passed with HTTP client creation and network requests blocked: exact JSON/TSV output, quiet output, hidden
showin group help, and no filtering/pagination options in list help. All standard output formats also completed successfully. No new live recordings are included because the visible list command does not make a service request.Review follow-up
Related AAZ model PR: Azure/aaz#1173. Verify generated-model synchronization before merge.
General Guidelines
azdev style horizondblocally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
Not applicable: this updates the existing HorizonDB extension.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.🐾 Generated with PAW