Repository navigation
{HORIZONDB} Add default parameter-group commands - #10604
Draft
Alex Hughes (alxhghs) wants to merge 1 commit into
Draft
Alex Hughes (alxhghs) wants to merge 1 commit into
Alex Hughes (alxhghs) wants to merge 1 commit into
Conversation
Generate regional default parameter-group list and show commands with aaz-dev 4.7.2, add request/pagination/output tests, and document the new commands in release 1.0.0b10. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9ee69131-bc2b-48ab-a83f-c95d1d156eb6
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR description lacks the corresponding Azure/aaz model PR link, leaving synchronization of generated command arguments and regional resource paths with the source model unverified.
1 open issue
What changed in this PR
Adds regional default parameter-group discovery to the HorizonDB extension, allowing users to list available defaults and inspect their engine-defined parameters.
Changes:
- Adds preview
default listanddefault showcommands using API version2026-10-01-preview. - Adds unit tests for request construction, pagination, empty results, and metadata preservation.
- Documents the commands and advances the extension to
1.0.0b10.
| File | Description |
|---|---|
src/horizondb/setup.py |
Bumps the package version to 1.0.0b10. |
src/horizondb/README.md |
Adds command examples and reference entries. |
src/horizondb/HISTORY.rst |
Records the new commands in release notes. |
src/horizondb/azext_horizondb/tests/latest/unittest_default_parameter_group.py |
Tests requests, pagination, and output preservation. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/parameter_group/default/_show.py |
Implements regional default-group retrieval. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/parameter_group/default/_list.py |
Implements paginated regional default-group listing. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/parameter_group/default/__init__.py |
Exposes the generated group and commands. |
src/horizondb/azext_horizondb/aaz/latest/horizondb/parameter_group/default/__cmd_group.py |
Registers the preview default parameter-group command group. |
Review effort: Balanced
| _aaz_info = { | ||
| "version": "2026-10-01-preview", | ||
| "resources": [ | ||
| ["mgmt-plane", "/subscriptions/{}/providers/microsoft.horizondb/locations/{}/parametergroups", "2026-10-01-preview"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤖 PR Validation —⚠️ Review suggested
Generate regional default parameter-group list and show commands with aaz-dev 4.7.2, add request/pagination/output tests, and document the new commands in release 1.0.0b10.
Uses Microsoft.HorizonDb API version
2026-10-01-preview. Existing custom parameter-group commands are unchanged.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az horizondb parameter-group default listaz horizondb parameter-group default showCompanion AAZ model PR: Not yet published. The models are prepared and validated; the corresponding Azure/aaz PR link still needs to be added to resolve the model-synchronization review comment.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)The local index-test checkbox is intentionally unchecked: the command was not run locally. The CI "Verify Extensions Index" check passed for head
93f0c3b7fwhen checked. This PR does not modifysrc/index.json.For new extensions:
Not applicable: this updates the existing HorizonDB extension rather than adding a new extension.
Validation evidence
Run from the repository root with
.azdev-venvconfigured andPYTHONPATHpointing tosrc\horizondb:.\.azdev-venv\Scripts\python.exe -m unittest discover -s src\horizondb\azext_horizondb\tests\latest -p 'unittest*.py'- passed: 55 tests, including the three new default parameter-group tests..\.azdev-venv\Scripts\python.exe -m pytest -q src\horizondb\azext_horizondb\tests\latest\test_horizondb_parameter_group.py- passed: one recorded scenario withAZURE_TEST_MODE=playback..\.azdev-venv\Scripts\azdev.exe style horizondb- passed: pylint and flake8.git diff --check origin/main...HEAD- passed.python scripts/ci/test_index.py -q- not run locally; CI index verification passed for the head identified above.Both AAZ resource configurations validate and regenerate all four new CLI files byte-for-byte. The complete REST list/show example responses deserialize without losing fields. No live Azure validation was run.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.