Skip to content

{HORIZONDB} Add default parameter-group commands - #10604

Draft
Alex Hughes (alxhghs) wants to merge 1 commit into
Azure:mainfrom
alxhghs:feature/horizondb-default-parameter-groups
Draft

Alex Hughes (alxhghs) wants to merge 1 commit into
Azure:mainfrom
alxhghs:feature/horizondb-default-parameter-groups

Conversation

@alxhghs

@alxhghs Alex Hughes (alxhghs) commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes Suppressions
⚠️ None ️✔️ None
⚠️Azure CLI Extensions Breaking Change Test
⚠️horizondb
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd horizondb parameter-group default sub group horizondb parameter-group default added

Generate regional default parameter-group list and show commands with aaz-dev 4.7.2, add request/pagination/output tests, and document the new commands in release 1.0.0b10.

Uses Microsoft.HorizonDb API version 2026-10-01-preview. Existing custom parameter-group commands are unchanged.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az horizondb parameter-group default list

az horizondb parameter-group default show

Companion AAZ model PR: Not yet published. The models are prepared and validated; the corresponding Azure/aaz PR link still needs to be added to resolve the model-synchronization review comment.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

The local index-test checkbox is intentionally unchecked: the command was not run locally. The CI "Verify Extensions Index" check passed for head 93f0c3b7f when checked. This PR does not modify src/index.json.

For new extensions:

Not applicable: this updates the existing HorizonDB extension rather than adding a new extension.

Validation evidence

Run from the repository root with .azdev-venv configured and PYTHONPATH pointing to src\horizondb:

  • .\.azdev-venv\Scripts\python.exe -m unittest discover -s src\horizondb\azext_horizondb\tests\latest -p 'unittest*.py' - passed: 55 tests, including the three new default parameter-group tests.
  • .\.azdev-venv\Scripts\python.exe -m pytest -q src\horizondb\azext_horizondb\tests\latest\test_horizondb_parameter_group.py - passed: one recorded scenario with AZURE_TEST_MODE=playback.
  • .\.azdev-venv\Scripts\azdev.exe style horizondb - passed: pylint and flake8.
  • git diff --check origin/main...HEAD - passed.
  • python scripts/ci/test_index.py -q - not run locally; CI index verification passed for the head identified above.

Both AAZ resource configurations validate and regenerate all four new CLI files byte-for-byte. The complete REST list/show example responses deserialize without losing fields. No live Azure validation was run.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Generate regional default parameter-group list and show commands with aaz-dev 4.7.2, add request/pagination/output tests, and document the new commands in release 1.0.0b10.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9ee69131-bc2b-48ab-a83f-c95d1d156eb6
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description lacks the corresponding Azure/aaz model PR link, leaving synchronization of generated command arguments and regional resource paths with the source model unverified.

1 open issue
What changed in this PR

Adds regional default parameter-group discovery to the HorizonDB extension, allowing users to list available defaults and inspect their engine-defined parameters.

Changes:

  • Adds preview default list and default show commands using API version 2026-10-01-preview.
  • Adds unit tests for request construction, pagination, empty results, and metadata preservation.
  • Documents the commands and advances the extension to 1.0.0b10.
File Description
src/​horizondb/​setup.py Bumps the package version to 1.0.0b10.
src/​horizondb/​README.md Adds command examples and reference entries.
src/​horizondb/​HISTORY.rst Records the new commands in release notes.
src/​horizondb/​azext_horizondb/​tests/​latest/​unittest_default_parameter_group.py Tests requests, pagination, and output preservation.
src/​horizondb/​azext_horizondb/​aaz/​latest/​horizondb/​parameter_group/​default/​_show.py Implements regional default-group retrieval.
src/​horizondb/​azext_horizondb/​aaz/​latest/​horizondb/​parameter_group/​default/​_list.py Implements paginated regional default-group listing.
src/​horizondb/​azext_horizondb/​aaz/​latest/​horizondb/​parameter_group/​default/​__init__.py Exposes the generated group and commands.
src/​horizondb/​azext_horizondb/​aaz/​latest/​horizondb/​parameter_group/​default/​__cmd_group.py Registers the preview default parameter-group command group.

Review effort: Balanced

_aaz_info = {
"version": "2026-10-01-preview",
"resources": [
["mgmt-plane", "/subscriptions/{}/providers/microsoft.horizondb/locations/{}/parametergroups", "2026-10-01-preview"],
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants