Skip to content

docs: clarify immutable subject claims setup and troubleshooting - #653

Merged
Yeming Liu (isra-fel) merged 2 commits into
masterfrom
docs-immutable-subject-claims
Nov 17, 2026
Merged

Yeming Liu (isra-fel) merged 2 commits into
masterfrom
docs-immutable-subject-claims

Conversation

@isra-fel

@isra-fel Yeming Liu (isra-fel) commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Explain immutable OIDC subject claims, their security benefit, and the required GitHub and Azure configuration, linking the GitHub announcement and both platforms' documentation.
  • Rename the numeric-ID troubleshooting entry to "Immutable subject claims enabled on Azure but not GitHub".
  • Recommend enabling immutable subject claims on both sides, with editing the Azure Subject to remove numeric IDs as the alternative.
  • Remove the outdated claim that GitHub never includes numeric IDs and avoid describing the portal ID fields as optional.

Related discussions: #652 and #617.

Validation

  • README Markdown lint passed.
  • git diff --check passed.
  • Documentation-only change; no action behavior changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 28d4d3bc-8553-4068-8689-4d0d39ac2d4c
Copilot AI balanced review requested due to automatic review settings November 17, 2026 02:52
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 28d4d3bc-8553-4068-8689-4d0d39ac2d4c

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for this documentation-only clarification of immutable OIDC subject claim setup and troubleshooting.

No open issues 🎉

What changed in this PR

Clarifies immutable OIDC subject claim setup for Azure Login and addresses the subject mismatches reported in #652 and #617. This is a documentation-only change with no action behavior changes.

Changes:

  • Explains immutable subject claims, their security benefit, and matching GitHub and Azure configuration.
  • Updates troubleshooting to recommend enabling immutable claims, with removing numeric IDs as an alternative.
  • Adds setup and migration references and a table-of-contents link.
File Description
README.md Adds immutable subject claim guidance and corrects numeric-ID mismatch troubleshooting.

Review effort: Balanced

@isra-fel
Yeming Liu (isra-fel) marked this pull request as ready for review November 17, 2026 02:55

@isra-fel Yeming Liu (isra-fel) left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel Yeming Liu (isra-fel) self-assigned this Nov 17, 2026
@isra-fel
Yeming Liu (isra-fel) merged commit 81f1f7d into master Nov 17, 2026
38 of 41 checks passed
@isra-fel
Yeming Liu (isra-fel) deleted the docs-immutable-subject-claims branch November 17, 2026 03:44

This branch was successfully deployed

1 active deployment
Automation test — 65384ff9 Deployed Nov 17, 2026 by isra-fel via Positive_InDockerTest #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants