Skip to content

VAPI-4422 Add Attestation Level and Identity to Transfer Verb #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nasanov-bw wants to merge 4 commits into
base: main
Choose a base branch
from
Open

VAPI-4422 Add Attestation Level and Identity to Transfer Verb #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19750b0
feat(VAPI-3321): add attestationLevel and identity attributes to Tran…
nasanov-bw Oct 20, 2026
0041f60
refactor(VAPI-4422): rename Transfer attestationLevel to requestedAtt…
nasanov-bw Nov 11, 2026
86ada3d
Merge remote-tracking branch 'origin/main' into VAPI-3321_transfer-at…
nasanov-bw Nov 11, 2026
cef442d
test(VAPI-4422): fold Transfer attestation and identity into existing…
nasanov-bw Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions models/bxml/verbs/Transfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ export interface TransferAttributes {
diversionTreatment?: string;
diversionReason?: string;
privacy?: boolean;
requestedAttestationLevel?: string;
identity?: string;
}

/**
Expand Down
14 changes: 8 additions & 6 deletions tests/unit/models/bxml/verbs/Transfer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,17 @@ describe('Transfer', () => {
tag: 'initialTag',
diversionTreatment: 'propagate',
diversionReason: 'user-busy',
privacy: true
privacy: true,
requestedAttestationLevel: 'B',
identity: 'eyJhbGciOiJFUzI1NiJ9.eyJhdHRlc3QiOiJBIn0.c2ln;info=<https://cert.example.com/cert.pem>;ppt="shaken"'
};

const phoneNumber = new PhoneNumber('+19195551234');
const sipUri = new SipUri('sip:1-999-123-4567@voip-provider.example.net');

test('should create a Transfer Verb', () => {
const transfer = new Transfer(attributes);
const expected = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true"/>';
const expected = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true" requestedAttestationLevel="B" identity="eyJhbGciOiJFUzI1NiJ9.eyJhdHRlc3QiOiJBIn0.c2ln;info=&lt;https://cert.example.com/cert.pem&gt;;ppt=&quot;shaken&quot;"/>';

expect(transfer).toBeInstanceOf(Transfer);
expect(transfer).toBeInstanceOf(Verb);
Expand All @@ -36,9 +38,9 @@ describe('Transfer', () => {

test('should create a Transfer Verb with nested PhoneNumber and SipUri', () => {
let transfer = new Transfer(attributes, phoneNumber);
const expected = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true"><PhoneNumber>+19195551234</PhoneNumber></Transfer>';
const expectedSingle = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true"><PhoneNumber>+19195551234</PhoneNumber><SipUri>sip:1-999-123-4567@voip-provider.example.net</SipUri></Transfer>';
const expectedMultiple = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true"><PhoneNumber>+19195551234</PhoneNumber><SipUri>sip:1-999-123-4567@voip-provider.example.net</SipUri><SipUri>sip:1-999-123-4567@voip-provider.example.net</SipUri><PhoneNumber>+19195551234</PhoneNumber></Transfer>';
const expected = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true" requestedAttestationLevel="B" identity="eyJhbGciOiJFUzI1NiJ9.eyJhdHRlc3QiOiJBIn0.c2ln;info=&lt;https://cert.example.com/cert.pem&gt;;ppt=&quot;shaken&quot;"><PhoneNumber>+19195551234</PhoneNumber></Transfer>';
const expectedSingle = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true" requestedAttestationLevel="B" identity="eyJhbGciOiJFUzI1NiJ9.eyJhdHRlc3QiOiJBIn0.c2ln;info=&lt;https://cert.example.com/cert.pem&gt;;ppt=&quot;shaken&quot;"><PhoneNumber>+19195551234</PhoneNumber><SipUri>sip:1-999-123-4567@voip-provider.example.net</SipUri></Transfer>';
const expectedMultiple = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true" requestedAttestationLevel="B" identity="eyJhbGciOiJFUzI1NiJ9.eyJhdHRlc3QiOiJBIn0.c2ln;info=&lt;https://cert.example.com/cert.pem&gt;;ppt=&quot;shaken&quot;"><PhoneNumber>+19195551234</PhoneNumber><SipUri>sip:1-999-123-4567@voip-provider.example.net</SipUri><SipUri>sip:1-999-123-4567@voip-provider.example.net</SipUri><PhoneNumber>+19195551234</PhoneNumber></Transfer>';

expect(transfer).toBeInstanceOf(Transfer);
expect(transfer).toBeInstanceOf(Verb);
Expand All @@ -53,7 +55,7 @@ describe('Transfer', () => {

test('should test the addTransferRecipients method method when no verbs are initially nested', () => {
const transfer = new Transfer(attributes);
const expected = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true"><PhoneNumber>+19195551234</PhoneNumber></Transfer>';
const expected = '<Transfer transferCallerId="+19195551234" transferCallerDisplayName="initialDisplayName" callTimeout="5" transferCompleteUrl="https://initial.com" transferCompleteMethod="POST" transferCompleteFallbackUrl="https://initial.com" transferCompleteFallbackMethod="POST" username="initialUsername" password="initialPassword" fallbackUsername="initialFallbackUsername" fallbackPassword="initialFallbackPassword" tag="initialTag" diversionTreatment="propagate" diversionReason="user-busy" privacy="true" requestedAttestationLevel="B" identity="eyJhbGciOiJFUzI1NiJ9.eyJhdHRlc3QiOiJBIn0.c2ln;info=&lt;https://cert.example.com/cert.pem&gt;;ppt=&quot;shaken&quot;"><PhoneNumber>+19195551234</PhoneNumber></Transfer>';

transfer.addTransferRecipients(phoneNumber);
expect(transfer.toBxml()).toBe(expected);
Expand Down