Skip to content

Fix Canvas default selection of latest generation takes - #26

Merged
erickkkyt merged 1 commit into
BeatAPI:mainfrom
JaysonAlbert:codex/fix-latest-generation-version
Oct 21, 2026
Merged

erickkkyt merged 1 commit into
BeatAPI:mainfrom
JaysonAlbert:codex/fix-latest-generation-version

Conversation

@JaysonAlbert

Copy link
Copy Markdown
Contributor

Canvas generation take thumbnails could highlight the first take even when the main preview displayed a newer result. Browser generation completion could also retain an older pinned take. The shared resolver now chooses the newest usable successful output independently of caller ordering, the preview uses that resolver, and completed browser generations select their new output. Manual history selection and timeline asset pinning are preserved.

Fixes #25.

Validation on this upstream baseline: TypeScript, i18n, production build, 16 focused unit regressions and 2 Chrome regressions passed (image/video default selection, preview URL, manual selection and reload persistence). Includes a tiny synthetic black MP4 fixture. No provider generation was submitted. The complete suite was also run; Windows-specific baseline failures are described in the follow-up validation note.

The same fix is available in the maintained Fork via JaysonAlbert#13; this branch is based on upstream main and contains no local provider or workstation configuration.

@JaysonAlbert

Copy link
Copy Markdown
Contributor Author

Validation details for the upstream branch on Windows: 16 focused unit tests and both Chrome image/video regressions pass, along with typecheck, i18n and production build. The full suite reports 409 passed, 10 failed, 2 skipped. Failures are outside the changed feature files: Unix-only expected paths, unprivileged directory symlink creation, SQLite temporary-file cleanup, spawning the Unix tsx shim on Windows, a provider integration harness, and LF-only WorkBuddy frontmatter validation against the checkout's CRLF files. Those portability changes were deliberately kept out of this PR. On the maintained Fork (which already has the local portability fixes), the full suite reports 460 passed, 0 failed, 5 skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canvas generation history defaults to the first take instead of the latest successful version

2 participants