docs(maintenance): tier 1 maintenance, documentation & test baselines - #2368
docs(maintenance): tier 1 maintenance, documentation & test baselines#2368BigSimmo wants to merge 7 commits into
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedNext included review available in 42 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 96 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (5)
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Tautological contract baseline assertion
- The baseline now reads the nine planned contract files and pins their tallied executed case count (135), so adding or removing cases fails the test.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 11279d2. Configure here.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11279d22a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The 9-suite baseline compared a local 133 to itself, so adding or removing cases in the planned contract files could not fail the pin. Read those files and assert the executed case count (135).
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #13894 (success). That run's conclusion is an aggregate and did not exercise Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
…20260825 # Conflicts: # data/repo-awareness-snapshot.json
…20260825 # Conflicts: # data/repo-awareness-snapshot.json



Summary
Executes the Tier 1 Ultra-Fast Maintenance, Documentation & Test Baselines engineering batch across 8 items:
/ward-management/constellationCompatibility Redirect (b5d6b1be): Documented/ward-management/constellationas an intentional, unlinked backwards-compatibility redirect to/ward-management/networkinscripts/generate-site-map.tsand regenerateddocs/site-map.md.#RVK6BJ): Audited and purged 7 empty unlinked directories under.claude/worktrees/.#61TZJA): Documented Linux container visual baseline adoption and regeneration viascripts/adopt-visual-baselines.mjsindocs/testing.md.#TF6TPJ): Addeddocs/continuous-integration.mddetailing the base-branch concurrency architecture, push exemption fromcancel-in-progress, and Guard 2 in-flight CI push guard (inFlightCiGuard). Cross-linked inci-operations.mdandREADME.md.clinical-hazard-analysis.md(#778Q0H): Added explicit heading and anchors (#h5-provenance-tagsand#h5-provenance-tags-and-synthetic-summaries).#XCAX01): Added contract baseline test intests/verify-phone-chrome.test.tsverifying all 9 suites with 135 executed contracts.#HVTYAT): Updated.claude/hooks/session-start.shto emit valid JSON on stdout matching{"hookSpecificOutput":{"hookEventName":"SessionStart","additionalContext":"..."}}when executed in hook mode; added dedicated unit test intests/session-start-hook.test.ts; preserved100755file mode and LF line endings.#V0EDR4): Updateddocs/launch-operator-runbook.mdanddocs/worker-deploy-runbook.mdto require Node 24.15.0+ and npm 11 engines.Verification
28d62ff0bc46839f656d653bc5fbb3d0466b012a:npm run format,npm run sitemap:check,npm run check:repo-awareness-snapshot, andgit diff --checkall passed.npm run docs:check-links-> PASS (3,413 references resolve)npm run docs:check-index-> PASS (all 63 modules and schema tables indexed)npm run sitemap:check-> PASS (site-map.md matches route scanner)npx vitest run tests/session-start-hook.test.ts tests/verify-phone-chrome.test.ts-> PASS (31/31 tests)npm run typecheck:source:internal-> PASS (0 type errors)git diff --check-> PASS (0 whitespace errors)git ls-files -s .claude/hooks/*.sh-> PASS (all 5 hooks mode 100755)Invariant Compliance
src/lib/rag*,src/lib/auth*, or database credentials modified.Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)> [!NOTE]
> Low Risk
> Docs and test/documentation hooks only; session-start JSON output is confined to remote Claude hook mode with no changes to clinical or auth paths.
>
> Overview
> Tier 1 maintenance batch: documentation, Claude SessionStart hook behavior, and test baseline pins—no product/RAG/auth code.
>
> Claude Code web:
session-start.shnow reads the hook stdin payload, records a dependency-install status message, and prints SessionStarthookSpecificOutputJSON on stdout (Node/npm versions + install outcome) whenCLAUDE_ENV_FILEis set or the payload names SessionStart. A new unit test asserts that JSON shape.>
> Docs: New
docs/continuous-integration.mddocumentsci.yml/ eval-canary concurrency and Guard 2 (in-flight CI push guard inscripts/guard-push.mjs), with cross-links fromREADME.mdandci-operations.md. Operator runbooks add Node 24.15+ / npm 11 pre-flight checks viacheck:runtime.testing.mddocuments adopting Linux visual baselines from CI artifacts viascripts/adopt-visual-baselines.mjs. Ward Management/ward-management/constellationis documented as an intentional unlinked redirect to/ward-management/network(site-map generator + regeneratedsite-map.md).clinical-hazard-analysis.mdadds explicit H5 provenance heading anchors.>
> Tests:
verify-phone-chrome.test.tspins the 9-suite phone-chrome contract file list (and a 135 contract count baseline constant).>
> Reviewed by Cursor Bugbot for commit 11279d2. Configure here.