Skip to content

docs(maintenance): tier 1 maintenance, documentation & test baselines - #2368

Open
BigSimmo wants to merge 7 commits into
mainfrom
tier_1_maintenance_sweep
Open

docs(maintenance): tier 1 maintenance, documentation & test baselines#2368
BigSimmo wants to merge 7 commits into
mainfrom
tier_1_maintenance_sweep

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

Executes the Tier 1 Ultra-Fast Maintenance, Documentation & Test Baselines engineering batch across 8 items:

  1. Document /ward-management/constellation Compatibility Redirect (b5d6b1be): Documented /ward-management/constellation as an intentional, unlinked backwards-compatibility redirect to /ward-management/network in scripts/generate-site-map.ts and regenerated docs/site-map.md.
  2. Purge Empty Unregistered Worktrees (#RVK6BJ): Audited and purged 7 empty unlinked directories under .claude/worktrees/.
  3. Re-adopt Linux Visual Baseline for CI (#61TZJA): Documented Linux container visual baseline adoption and regeneration via scripts/adopt-visual-baselines.mjs in docs/testing.md.
  4. Document & Verify CI Push Guard Concurrency (#TF6TPJ): Added docs/continuous-integration.md detailing the base-branch concurrency architecture, push exemption from cancel-in-progress, and Guard 2 in-flight CI push guard (inFlightCiGuard). Cross-linked in ci-operations.md and README.md.
  5. Fix Broken Anchor Link in clinical-hazard-analysis.md (#778Q0H): Added explicit heading and anchors (#h5-provenance-tags and #h5-provenance-tags-and-synthetic-summaries).
  6. Update Phone-Chrome Baseline Test Count (#XCAX01): Added contract baseline test in tests/verify-phone-chrome.test.ts verifying all 9 suites with 135 executed contracts.
  7. SessionStart Hook JSON Stdout Unit Test (#HVTYAT): Updated .claude/hooks/session-start.sh to emit valid JSON on stdout matching {"hookSpecificOutput":{"hookEventName":"SessionStart","additionalContext":"..."}} when executed in hook mode; added dedicated unit test in tests/session-start-hook.test.ts; preserved 100755 file mode and LF line endings.
  8. Update Launch Runbook Node Engine Floor (#V0EDR4): Updated docs/launch-operator-runbook.md and docs/worker-deploy-runbook.md to require Node 24.15.0+ and npm 11 engines.

Verification

  • Post-sync at 28d62ff0bc46839f656d653bc5fbb3d0466b012a: npm run format, npm run sitemap:check, npm run check:repo-awareness-snapshot, and git diff --check all passed.
  • npm run docs:check-links -> PASS (3,413 references resolve)
  • npm run docs:check-index -> PASS (all 63 modules and schema tables indexed)
  • npm run sitemap:check -> PASS (site-map.md matches route scanner)
  • npx vitest run tests/session-start-hook.test.ts tests/verify-phone-chrome.test.ts -> PASS (31/31 tests)
  • npm run typecheck:source:internal -> PASS (0 type errors)
  • git diff --check -> PASS (0 whitespace errors)
  • git ls-files -s .claude/hooks/*.sh -> PASS (all 5 hooks mode 100755)

Invariant Compliance

  • Zero RAG / Auth Changes: No files under src/lib/rag*, src/lib/auth*, or database credentials modified.
  • Provider Spend: Zero non-GitHub provider-backed API calls or deployments made.

Risk and rollout

  • Risk: low; documentation, hook output, and contract-baseline changes only. The main sync preserved current base behavior and regenerated the committed site-map and repository-awareness outputs from their owning scripts.
  • Rollback: revert the merge/snapshot-sync commits before merge, or revert this PR after merge.
  • Provider or production effects: None. Only the explicitly authorized GitHub branch and CI operations were performed.
  • RAG impact: none.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

> [!NOTE]
> Low Risk
> Docs and test/documentation hooks only; session-start JSON output is confined to remote Claude hook mode with no changes to clinical or auth paths.
>
> Overview
> Tier 1 maintenance batch: documentation, Claude SessionStart hook behavior, and test baseline pins—no product/RAG/auth code.
>
> Claude Code web: session-start.sh now reads the hook stdin payload, records a dependency-install status message, and prints SessionStart hookSpecificOutput JSON on stdout (Node/npm versions + install outcome) when CLAUDE_ENV_FILE is set or the payload names SessionStart. A new unit test asserts that JSON shape.
>
> Docs: New docs/continuous-integration.md documents ci.yml / eval-canary concurrency and Guard 2 (in-flight CI push guard in scripts/guard-push.mjs), with cross-links from README.md and ci-operations.md. Operator runbooks add Node 24.15+ / npm 11 pre-flight checks via check:runtime. testing.md documents adopting Linux visual baselines from CI artifacts via scripts/adopt-visual-baselines.mjs. Ward Management /ward-management/constellation is documented as an intentional unlinked redirect to /ward-management/network (site-map generator + regenerated site-map.md). clinical-hazard-analysis.md adds explicit H5 provenance heading anchors.
>
> Tests: verify-phone-chrome.test.ts pins the 9-suite phone-chrome contract file list (and a 135 contract count baseline constant).
>
> Reviewed by Cursor Bugbot for commit 11279d2. Configure here.

@supabase

supabase Bot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 42 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 96 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f1867802-d671-4d36-812b-01222f2745b1

📥 Commits

Reviewing files that changed from the base of the PR and between 069058a and 28d62ff.

⛔ Files ignored due to path filters (8)
  • docs/README.md is excluded by !docs/**, !**/*.md
  • docs/ci-operations.md is excluded by !docs/**, !**/*.md
  • docs/clinical-hazard-analysis.md is excluded by !docs/**, !**/*.md
  • docs/continuous-integration.md is excluded by !docs/**, !**/*.md
  • docs/launch-operator-runbook.md is excluded by !docs/**, !**/*.md
  • docs/site-map.md is excluded by !docs/**, !**/*.md
  • docs/testing.md is excluded by !docs/**, !**/*.md
  • docs/worker-deploy-runbook.md is excluded by !docs/**, !**/*.md
📒 Files selected for processing (5)
  • .claude/hooks/session-start.sh
  • data/repo-awareness-snapshot.json
  • scripts/generate-site-map.ts
  • tests/session-start-hook.test.ts
  • tests/verify-phone-chrome.test.ts

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Tautological contract baseline assertion
    • The baseline now reads the nine planned contract files and pins their tallied executed case count (135), so adding or removing cases fails the test.

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 11279d2. Configure here.

Comment thread tests/verify-phone-chrome.test.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Left a non-blocking comment and did not approve. Cursor Bugbot reported one unresolved medium-severity finding on the phone-chrome contract baseline that needs human review. No additional reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11279d22a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/verify-phone-chrome.test.ts Outdated
The 9-suite baseline compared a local 133 to itself, so adding or
removing cases in the planned contract files could not fail the pin.
Read those files and assert the executed case count (135).
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

  • Production UI (2)not baselined: this job did NOT run on the main comparison below (path-scoped skip), so that run says nothing about it either way. Treat the comparison as absent, not green, and inspect the failing step.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #13894 (success). That run's conclusion is an aggregate and did not exercise Production UI (2).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

cursor[bot]
cursor Bot previously approved these changes Aug 25, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Approved. Cursor Bugbot’s prior medium-severity finding was marked fixed by Autofix and is no longer present on this head; no Bugbot check is running on the current commit. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@BigSimmo
BigSimmo enabled auto-merge (squash) August 25, 2026 03:54
cursor[bot]
cursor Bot previously approved these changes Aug 25, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Approved. Cursor Bugbot is not running on this head; the prior medium-severity baseline finding is fixed in the current test and no approval policy requires human review. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

…20260825

# Conflicts:
#	data/repo-awareness-snapshot.json
cursor[bot]
cursor Bot previously approved these changes Aug 25, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Approved. Cursor Bugbot is not running on this head; the prior medium-severity baseline finding is resolved and no approval policy requires human review. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot is not running on this head; the prior medium-severity baseline finding is resolved and no approval policy requires human review. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants