Skip to content

fix(router_core): re-sync to router-core 273c2af (2026-11 audit) — 88/88 parity - #102

Merged
VickyXAI merged 1 commit into
mainfrom
fix/router-core-parity-audit
Nov 8, 2026
Merged

VickyXAI merged 1 commit into
mainfrom
fix/router-core-parity-audit

Conversation

@VickyXAI

@VickyXAI VickyXAI commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Ports the router-core audit (BlockRunAI/router-core#12, merged as 273c2af) onto the current 8773a99 port. All 88 cross-language snapshot decisions match the TypeScript engine.

  • portfolio:
    • Chinese task keywords moved outside the ASCII \b, so they match again.
    • A coding action is now required before a language name sends a tool turn to code_agent.
    • Tool-name verbs match whole words; reservation ids need both a letter and a digit.
    • Kana excludes a prompt from zh; the multi-location connector is stricter.
    • An unpriced candidate scores cost 0; malformed performance profiles are ignored.
  • rules: only line-leading numbered lists count as multi-step; full-width ? counts as a question.
  • selector: new usable_pricing; calculate_model_cost reports no savings for an unpriced model.
  • tokens: the scan stays bounded at limit 1 and for non-numeric limits.
  • model_capabilities: synced to the 2026-11-08 catalog. kimi-k3 is retained because it is still routed and served; DeepSeek vision fails closed.

(This branch was rebuilt on current main. The first version was based on a stale checkout and duplicated #87/#90.)

Not included: upstream's catalog module. The SDK already does this through router_adapter.build_model_pricing, and routing parity does not depend on it.

Test plan

  • pytest tests/unit: 1469 passed. The 29 new tests in test_router_core_audit.py port upstream hardening.test.ts; 15 of them fail on main.
  • Snapshot parity: 88/88 against router-core 273c2af
  • ruff check / ruff format clean; mypy shows no router_core errors

🤖 Generated with Claude Code

@VickyXAI VickyXAI changed the title fix(router_core): re-sync to router-core fdfac23 — 88/88 decision parity fix(router_core): re-sync to router-core 273c2af — 88/88 decision parity Nov 8, 2026
Ports the router-core audit (BlockRunAI/router-core#12) onto the 8773a99
port. All 88 cross-language snapshot decisions match again.

- portfolio: Chinese task keywords outside the ASCII \b; coding-action
  gate for code_agent; whole-word tool verbs; letter+digit reservation ids;
  kana excluded from zh; strict multi-location connector; unpriced
  candidates score cost 0; malformed performance profiles ignored.
- rules: line-leading numbered lists only; full-width question marks.
- selector: usable_pricing; no savings for an unpriced model in
  calculate_model_cost.
- tokens: bounded scan at limit 1 and for non-numeric limits.
- model_capabilities: 2026-11-08 catalog (kimi-k3 retained, DeepSeek
  vision fails closed).

29 new tests port upstream hardening.test.ts; 15 fail on the previous port.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@VickyXAI
VickyXAI force-pushed the fix/router-core-parity-audit branch from 4fa8dba to ec2a1df Compare November 8, 2026 14:27
@VickyXAI VickyXAI changed the title fix(router_core): re-sync to router-core 273c2af — 88/88 decision parity fix(router_core): re-sync to router-core 273c2af (2026-11 audit) — 88/88 parity Nov 8, 2026
@VickyXAI
VickyXAI merged commit a84ca2d into main Nov 8, 2026
6 checks passed
@VickyXAI
VickyXAI deleted the fix/router-core-parity-audit branch November 9, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant