Skip to content

fix: read active contracts through eventFormat #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmcorbalan merged 1 commit into from
Nov 6, 2026
Merged

fix: read active contracts through eventFormat #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions registry/src/ledger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,10 @@ export class HttpLedgerClient implements LedgerClient {
method: 'POST',
headers: this.headers(),
body: JSON.stringify({
filter: templateFilter(templateId, party, includeCreatedEventBlob),
verbose: false,
eventFormat: {
...templateFilter(templateId, party, includeCreatedEventBlob),
verbose: false,
},
activeAtOffset,
}),
})
Expand Down
8 changes: 5 additions & 3 deletions registry/test/ledger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ describe('HttpLedgerClient.activeContracts', () => {
expect(url).toBe('http://ledger/v2/state/active-contracts')
expect(init.method).toBe('POST')
const body = JSON.parse(init.body as string)
expect(body).not.toHaveProperty('filter')
expect(body).not.toHaveProperty('verbose')
expect(
body.filter.filtersByParty['admin::1'].cumulative[0].identifierFilter.TemplateFilter.value
.templateId,
body.eventFormat.filtersByParty['admin::1'].cumulative[0].identifierFilter.TemplateFilter
.value.templateId,
).toBe('pkg:Canton.TokenForge.Registry:InstrumentConfig')
})

Expand Down Expand Up @@ -191,7 +193,7 @@ describe('HttpLedgerClient.probeTemplate', () => {
expect(body.activeAtOffset).toBe(0)
// And no disclosure blob, which is the bulk of a row and is what a
// counterparty needs rather than a check that reads nothing back.
const filter = body.filter.filtersByParty['admin::1'].cumulative[0].identifierFilter
const filter = body.eventFormat.filtersByParty['admin::1'].cumulative[0].identifierFilter
expect(filter.TemplateFilter.value).toEqual({
templateId: 'pkg:M:LockedToken',
includeCreatedEventBlob: false,
Expand Down
4 changes: 2 additions & 2 deletions scripts/seed.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ async function ledgerEnd() {

async function activeContracts(templateId, party) {
const rows = await call('/v2/state/active-contracts', {
filter: {
eventFormat: {
filtersByParty: {
[party]: {
cumulative: [
Expand All @@ -177,8 +177,8 @@ async function activeContracts(templateId, party) {
],
},
},
verbose: false,
},
verbose: false,
activeAtOffset: await ledgerEnd(),
})
return rows.flatMap((row) => {
Expand Down
Loading