[vishal-tambi]

save-html --no-images ignored the global -o and wrote the HTML to the working directory, which is why test_cli_save_html left goldeneye-Scenes.html in the repo root. CliContext.save_images_result started as (None, None) instead of None, so save_html took its output folder from a save-images run that never happened. It now starts as None, and the test checks that the file lands in the -o folder.

[Breakthrough]

with --no-images, save-html ignores -o. CliContext.save_images_result starts as (None, None) instead of None, so save_html takes its output folder from a save-images run that never happened. I can fix that in a separate PR if you'd like.

Thanks for kicking this off. We should change that behaviour to fix this properly here. By -o do you mean the global or local directory option (or both)?

[vishal-tambi]

Just the global -o, since save-html doesn't have a local one. Fixed it here: save_images_result now starts as None, so --no-images writes to -o, and the test checks that.

[Breakthrough]

Just the global -o, since save-html doesn't have a local one. Fixed it here: save_images_result now starts as None, so --no-images writes to -o, and the test checks that.

Should we add one as well?

[Breakthrough]

LGTM, will merge after you take a look at last set of comments/questions. Thanks for the PR!

[Breakthrough]

Good find, this is quite subtle. Should we make the type hint here ty.any | None?

[vishal-tambi]

ty.Any already allows None, so I used the real type instead: tuple[dict[int, list[str]], str | None] | None. Pyright is still clean.

[vishal-tambi]

Should we add one as well?

I'd do that in a separate PR, and I can open it after this one merges. The HTML links to images with paths relative to the save-images folder, so a local -o would need those links fixed too.

thanks