Repository navigation
refactor: optimize is_detector by using raw int set - #250
Closed
SamOgon-one wants to merge 2 commits into
Closed
SamOgon-one wants to merge 2 commits into
SamOgon-one wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes
unit.is_detectorby replacingUnitTypeIdenum lookups with a raw integerfrozenset[int]check, reordering boolean conditions for faster short-circuiting, and using a standard@property.Eliminates enum conversion overhead: Directly checks the raw Protobuf integer against
IS_DETECTOR_TYPESinstead of converting it into aUnitTypeIdenum viaself.type_id.Faster on fresh units: In
python-sc2,Unitinstances are recreated every frame, andis_detectoris typically queried only zero or one time per unit.@cached_propertyis way slower on the first call on fresh units due to writing intounit.__dict__.