Repository navigation
Improve metadata checking errors - #85
Merged
Merged
Conversation
…hat matches validation errors format
Coverage Report for CI Build 39601897454Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-2.2%) to 89.686%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves form validation and error handling in both the backend (
biosimdb_interface/form/utils.py,biosimdb_interface/form/webform.py) and frontend (biosimdb_interface/static/js/form/metadata.js) of the metadata submission workflow.Backend: Improved error handling and validation
FormConversionErrorexception to collect and report all form conversion errors with detailed messages, and updatedform_to_jsonto raise this error when issues are detected./webformendpoint logic by splitting it into separate GET and POST handlers, with POST now returning grouped validation errors and handling both "save" and "submit" actions using dedicated handler functions._parse_vectorhelper that supports both flat and multi-row vectors, with robust error messages for malformed input.Frontend: Better validation feedback and field highlighting
is-invalidstyling. This allows users to easily see which fields need correction.setNestedFieldsto support both flat and multi-row vectors, matching the backend's new parsing logic.Tests: Inclusion of MetadataValidationError
Impact